From 9cd1ddce7983960382d809adb8339effff58b3a6 Mon Sep 17 00:00:00 2001 From: neale Date: Wed, 15 Oct 2008 22:28:42 -0400 Subject: --- doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'doc/bugs') diff --git a/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn b/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn index 8cfd42e78..eb5fe5ce9 100644 --- a/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn +++ b/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn @@ -11,3 +11,7 @@ If I then inline that page, the (relative) URL no longer points to the right pla > > However, there is a simple way to avoid both problems: Use WikiLinks > and/or the [[img_directive|ikiwiki/directive/img]]. --[[Joey]] + +>> It would be nice if inlining a page just gave a tiny version of that page, though. +>> An iframe would be one way to do it, maybe not optimal. The presence of WikiLinks +>> and the img directive certainly make this a low-priority bug, though. --[[neale]] -- cgit v1.2.3 From 0414c629b6a33fbc1d0f93d76fe29d75bea452df Mon Sep 17 00:00:00 2001 From: neale Date: Wed, 15 Oct 2008 22:29:29 -0400 Subject: --- doc/bugs/neale.mdwn | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/bugs/neale.mdwn (limited to 'doc/bugs') diff --git a/doc/bugs/neale.mdwn b/doc/bugs/neale.mdwn new file mode 100644 index 000000000..364e58a02 --- /dev/null +++ b/doc/bugs/neale.mdwn @@ -0,0 +1 @@ +I have a keyboard and I'm not afraid to use it. -- cgit v1.2.3 From 9ae956e829c9aa50d978e0629ec7cda4e2854717 Mon Sep 17 00:00:00 2001 From: neale Date: Wed, 15 Oct 2008 22:30:36 -0400 Subject: --- doc/bugs/neale.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc/bugs') diff --git a/doc/bugs/neale.mdwn b/doc/bugs/neale.mdwn index 364e58a02..53ccd5e73 100644 --- a/doc/bugs/neale.mdwn +++ b/doc/bugs/neale.mdwn @@ -1 +1 @@ -I have a keyboard and I'm not afraid to use it. +Crud, I made the wrong page. I lose. -- cgit v1.2.3 From 0543e59eca1db017fd40a130e0af210cbbe16a52 Mon Sep 17 00:00:00 2001 From: neale Date: Wed, 15 Oct 2008 23:12:25 -0400 Subject: ahh --- doc/bugs/neale.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc/bugs') diff --git a/doc/bugs/neale.mdwn b/doc/bugs/neale.mdwn index 53ccd5e73..8b1378917 100644 --- a/doc/bugs/neale.mdwn +++ b/doc/bugs/neale.mdwn @@ -1 +1 @@ -Crud, I made the wrong page. I lose. + -- cgit v1.2.3 From c2bff24c6578c7ee263afc4ed28af64d99106bae Mon Sep 17 00:00:00 2001 From: neale Date: Wed, 15 Oct 2008 23:13:40 -0400 Subject: Oh well. --- doc/bugs/neale.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc/bugs') diff --git a/doc/bugs/neale.mdwn b/doc/bugs/neale.mdwn index 8b1378917..592b332ec 100644 --- a/doc/bugs/neale.mdwn +++ b/doc/bugs/neale.mdwn @@ -1 +1 @@ - +Hello everybody, I am an idiot and placed by user page in the bugs directory. -- cgit v1.2.3 From 594df81c54700cb46e4e9a7576ad70a2a2850958 Mon Sep 17 00:00:00 2001 From: neale Date: Wed, 15 Oct 2008 23:14:31 -0400 Subject: Joey's right, that's good enough. --- doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn | 4 ---- 1 file changed, 4 deletions(-) (limited to 'doc/bugs') diff --git a/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn b/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn index eb5fe5ce9..8cfd42e78 100644 --- a/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn +++ b/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn @@ -11,7 +11,3 @@ If I then inline that page, the (relative) URL no longer points to the right pla > > However, there is a simple way to avoid both problems: Use WikiLinks > and/or the [[img_directive|ikiwiki/directive/img]]. --[[Joey]] - ->> It would be nice if inlining a page just gave a tiny version of that page, though. ->> An iframe would be one way to do it, maybe not optimal. The presence of WikiLinks ->> and the img directive certainly make this a low-priority bug, though. --[[neale]] -- cgit v1.2.3 From 995d91675ebfa033eba162dad6e38185aa164a3e Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 15 Oct 2008 23:47:12 -0400 Subject: rm --- doc/bugs/neale.mdwn | 1 - 1 file changed, 1 deletion(-) delete mode 100644 doc/bugs/neale.mdwn (limited to 'doc/bugs') diff --git a/doc/bugs/neale.mdwn b/doc/bugs/neale.mdwn deleted file mode 100644 index 592b332ec..000000000 --- a/doc/bugs/neale.mdwn +++ /dev/null @@ -1 +0,0 @@ -Hello everybody, I am an idiot and placed by user page in the bugs directory. -- cgit v1.2.3 From 0517f9126cff724e62d92e4f637a1eca20f31ed7 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 15 Oct 2008 23:50:20 -0400 Subject: close --- doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/bugs') diff --git a/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn b/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn index 8cfd42e78..8cda7a70f 100644 --- a/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn +++ b/doc/bugs/images_in_inlined_pages_have_wrong_relative_URL.mdwn @@ -11,3 +11,5 @@ If I then inline that page, the (relative) URL no longer points to the right pla > > However, there is a simple way to avoid both problems: Use WikiLinks > and/or the [[img_directive|ikiwiki/directive/img]]. --[[Joey]] + +[[!tag done]] -- cgit v1.2.3 From 3690864e2ba9028f6440df6a12610a2499dea9c5 Mon Sep 17 00:00:00 2001 From: "http://jblevins.org/" Date: Fri, 17 Oct 2008 19:52:42 -0400 Subject: Patch for anchor-based change permalinks in recent changes feed --- doc/bugs/recentchanges_feed_links.mdwn | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'doc/bugs') diff --git a/doc/bugs/recentchanges_feed_links.mdwn b/doc/bugs/recentchanges_feed_links.mdwn index 14f1c26ba..9b2828901 100644 --- a/doc/bugs/recentchanges_feed_links.mdwn +++ b/doc/bugs/recentchanges_feed_links.mdwn @@ -92,3 +92,7 @@ to turn on? --Chapman Flack >>>>> required to compare ``s as opaque strings. >>>>> >>>>> --[[smcv]] + +>>>>>> Here's my attempt at a [[patch]] for anchor-based change permalinks: +>>>>>> . +>>>>>> --[[JasonBlevins]], 2008-10-17 -- cgit v1.2.3 From 35c56622ea56c7d97299faba5e72b5a67fa25c66 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 17 Oct 2008 21:54:42 -0400 Subject: tweak recentchanges permalink code Need to handle the case where url is not set. --- IkiWiki/Plugin/recentchanges.pm | 7 ++++--- debian/changelog | 2 ++ doc/bugs/recentchanges_feed_links.mdwn | 2 ++ templates/change.tmpl | 2 ++ 4 files changed, 10 insertions(+), 3 deletions(-) (limited to 'doc/bugs') diff --git a/IkiWiki/Plugin/recentchanges.pm b/IkiWiki/Plugin/recentchanges.pm index d0e4176ff..e124a4540 100644 --- a/IkiWiki/Plugin/recentchanges.pm +++ b/IkiWiki/Plugin/recentchanges.pm @@ -115,8 +115,6 @@ sub store ($$$) { #{{{ my $change=shift; my $page="$config{recentchangespage}/change_".titlepage($change->{rev}); - my $baseurl = IkiWiki::baseurl(); - my $permalink="$baseurl$config{recentchangespage}/#change-".titlepage($change->{rev}); # Optimisation to avoid re-writing pages. Assumes commits never # change (or that any changes are not important). @@ -177,8 +175,11 @@ sub store ($$$) { #{{{ commitdate => displaytime($change->{when}, "%X %x"), commitdate_raw => scalar localtime($change->{when}), wikiname => $config{wikiname}, - permalink => $permalink, ); + + $template->param(permalink => $config{url}."$config{recentchangespage}/#change-".titlepage($change->{rev})) + if exists $config{url}; + IkiWiki::run_hooks(pagetemplate => sub { shift->(page => $page, destpage => $page, template => $template, rev => $change->{rev}); diff --git a/debian/changelog b/debian/changelog index 908eb1f53..113a8a504 100644 --- a/debian/changelog +++ b/debian/changelog @@ -6,6 +6,8 @@ ikiwiki (2.68) UNRELEASED; urgency=low move it to toggle.js in the javascript underlay. * relativedate: New javascript-alicious plugin that makes all dates display relative, in a very nice way, if I say so myself. + * recentchanges: Make feed links point back to anchors on the recentchanges + page. (JasonBlevins) -- Joey Hess Fri, 17 Oct 2008 20:11:02 -0400 diff --git a/doc/bugs/recentchanges_feed_links.mdwn b/doc/bugs/recentchanges_feed_links.mdwn index 9b2828901..e3557a6cb 100644 --- a/doc/bugs/recentchanges_feed_links.mdwn +++ b/doc/bugs/recentchanges_feed_links.mdwn @@ -96,3 +96,5 @@ to turn on? --Chapman Flack >>>>>> Here's my attempt at a [[patch]] for anchor-based change permalinks: >>>>>> . >>>>>> --[[JasonBlevins]], 2008-10-17 + +[[done]] diff --git a/templates/change.tmpl b/templates/change.tmpl index 6647dfbca..c9e1a60d6 100644 --- a/templates/change.tmpl +++ b/templates/change.tmpl @@ -3,7 +3,9 @@ [[!meta authorurl=""""""]] [[!meta title="""change to on """]] + [[!meta permalink=""]] +