From 7188942440a434fcdc5943cb5cc5c15d9a4d65e7 Mon Sep 17 00:00:00 2001
From: "http://jmtd.net/" <http://jmtd.net/@web>
Date: Thu, 21 May 2009 05:15:11 -0400
Subject: non tag pages under the tagbase

---
 doc/bugs/tagged__40____41___matching_wikilinks.mdwn | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'doc/bugs')

diff --git a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
index 1bd556f50..40b5dd9e9 100644
--- a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
+++ b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
@@ -15,3 +15,5 @@ this is due to the wikilink being equal to a `\[[!tag ...]]`.  What's the
 rationale on this, or what am I doing wrong, and how to achieve what I want?
 
 --[[tschwinge]]
+
+: What you are doing "wrong" is putting non-tag pages (i.e. `/tag/open_issues_gdb.mdwn`) under your tagbase. -- [[Jon]]
-- 
cgit v1.2.3


From af7f2271ba8e35fbc49bd6b18fd9b8cf67ddc60e Mon Sep 17 00:00:00 2001
From: "http://jmtd.net/" <http://jmtd.net/@web>
Date: Thu, 21 May 2009 05:15:55 -0400
Subject: syntax confusion: tried to use ':' to indent.

---
 doc/bugs/tagged__40____41___matching_wikilinks.mdwn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'doc/bugs')

diff --git a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
index 40b5dd9e9..5de59fe88 100644
--- a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
+++ b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
@@ -16,4 +16,4 @@ rationale on this, or what am I doing wrong, and how to achieve what I want?
 
 --[[tschwinge]]
 
-: What you are doing "wrong" is putting non-tag pages (i.e. `/tag/open_issues_gdb.mdwn`) under your tagbase. -- [[Jon]]
+> What you are doing "wrong" is putting non-tag pages (i.e. `/tag/open_issues_gdb.mdwn`) under your tagbase. -- [[Jon]]
-- 
cgit v1.2.3


From d2071292f0f56954f01f52c0c8fd02922e9d5c21 Mon Sep 17 00:00:00 2001
From: "http://jmtd.net/" <http://jmtd.net/@web>
Date: Thu, 21 May 2009 05:17:08 -0400
Subject:

---
 doc/bugs/tagged__40____41___matching_wikilinks.mdwn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'doc/bugs')

diff --git a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
index 5de59fe88..bdd0c93c7 100644
--- a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
+++ b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
@@ -16,4 +16,4 @@ rationale on this, or what am I doing wrong, and how to achieve what I want?
 
 --[[tschwinge]]
 
-> What you are doing "wrong" is putting non-tag pages (i.e. `/tag/open_issues_gdb.mdwn`) under your tagbase. -- [[Jon]]
+> What you are doing "wrong" is putting non-tag pages (i.e. `/tag/open_issues_gdb.mdwn`) under your tagbase. The rationale for implementing tag as it has been, I think, is one of simplicity and conciseness. -- [[Jon]]
-- 
cgit v1.2.3


From 49635b0ca563b336a5ffc1d17a4197ee8b437018 Mon Sep 17 00:00:00 2001
From: Joey Hess <joey@gnu.kitenet.net>
Date: Thu, 21 May 2009 13:54:02 -0400
Subject: response

---
 doc/bugs/tagged__40____41___matching_wikilinks.mdwn | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

(limited to 'doc/bugs')

diff --git a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
index bdd0c93c7..2b30f247e 100644
--- a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
+++ b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
@@ -1,7 +1,10 @@
 It may be that I'm simply misunderstanding something, but what is the rationale
 for having `tagged()` also match normal wikilinks?
 
-> It simply hasn't been implemented yet -- see the answer in [[todo/tag_pagespec_function]]. Tags and wikilinks share the same underlying implementation, although ab reasonable expectation is that they are kept separate. --Ivan Z.
+> It simply hasn't been implemented yet -- see the answer in
+> [[todo/tag_pagespec_function]]. Tags and wikilinks share the same
+> underlying implementation, although ab reasonable expectation is that
+> they are kept separate. --Ivan Z.
 
 The following situation.  I have `tagbase => 'tag'`.  On some pages, scattered
 over the whole wiki, I use `\[[!tag open_issue_gdb]]` to declare that this page
@@ -16,4 +19,11 @@ rationale on this, or what am I doing wrong, and how to achieve what I want?
 
 --[[tschwinge]]
 
-> What you are doing "wrong" is putting non-tag pages (i.e. `/tag/open_issues_gdb.mdwn`) under your tagbase. The rationale for implementing tag as it has been, I think, is one of simplicity and conciseness. -- [[Jon]]
+> What you are doing "wrong" is putting non-tag pages (i.e.
+> `/tag/open_issues_gdb.mdwn`) under your tagbase. The rationale for
+> implementing tag as it has been, I think, is one of simplicity and
+> conciseness. -- [[Jon]]
+
+>> No, he has no pages under tagbase that aren't tags. This bug
+>> is valid. [[todo/matching_different_kinds_of_links]] is probably
+>> how it will eventually be solved. --[[Joey]] 
-- 
cgit v1.2.3


From 1a677f862c8a5e1e446adcea3f3737de07085c35 Mon Sep 17 00:00:00 2001
From: Joey Hess <joey@gnu.kitenet.net>
Date: Thu, 21 May 2009 14:00:55 -0400
Subject: response

---
 doc/bugs/SSI_include_stripped_from_mdwn.mdwn | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

(limited to 'doc/bugs')

diff --git a/doc/bugs/SSI_include_stripped_from_mdwn.mdwn b/doc/bugs/SSI_include_stripped_from_mdwn.mdwn
index bd895127a..5519e45c6 100644
--- a/doc/bugs/SSI_include_stripped_from_mdwn.mdwn
+++ b/doc/bugs/SSI_include_stripped_from_mdwn.mdwn
@@ -1,3 +1,21 @@
 If I have a &lt;--#include virtual="foo" --&gt; in some file, it gets stripped, even though other HTML comments don't get stripped. I imagine it's some plugin doing it, or IkiWiki itself, or an IkiWiki dependency, but I haven't found where this is happening. I'm trying to implement a workaround for my sidebars forcing a rebuild of the wiki every day - I use the calendar plugin - when the day changes, by using SSI.
 
 > It is probably the [[plugins/htmlscrubber]] plugin. -- [[Jon]]
+
+> htmlscrubber does strip these, because they look like
+> a html tag to it, not a html comment. (html comments start
+> with `<!--` .. of course, they get stripped too, because
+> they can be used to hide javascript..)
+> 
+> Anyway, it makes sense for the htmlscrubber to strip server-side
+> includes because otherwise your wiki could be attacked
+> by them being added to it. If you want to use both the htmlscrubber and
+> SSI together, I'd suggest you modify the [[wikitemplates]]
+> and put the SSI on there.
+> 
+> Ie, `page.tmpl` has a 
+> div that the sidebar is put into; if you just replace
+> that with the SSI that includes your static sidebar,
+> you should be good to go. --[[Joey]]
+
+[[done]]
-- 
cgit v1.2.3


From fe9183a926f33c29c026be774a5a6d286933bcc4 Mon Sep 17 00:00:00 2001
From: Joey Hess <joey@gnu.kitenet.net>
Date: Thu, 21 May 2009 14:15:50 -0400
Subject: response

---
 ..._wrap_HTML_container_around_a_set_of_inlined_pages.mdwn | 14 ++++++++++++++
 doc/wikitemplates.mdwn                                     |  2 ++
 2 files changed, 16 insertions(+)

(limited to 'doc/bugs')

diff --git a/doc/bugs/no_easy_way_to_wrap_HTML_container_around_a_set_of_inlined_pages.mdwn b/doc/bugs/no_easy_way_to_wrap_HTML_container_around_a_set_of_inlined_pages.mdwn
index 85c2d0c6c..1c1cbbb73 100644
--- a/doc/bugs/no_easy_way_to_wrap_HTML_container_around_a_set_of_inlined_pages.mdwn
+++ b/doc/bugs/no_easy_way_to_wrap_HTML_container_around_a_set_of_inlined_pages.mdwn
@@ -7,3 +7,17 @@ with a template definition like
     <div id="foo">\[[!inline ... pages="<TMPL_VAR raw_pages>"]]</div>
 
 It would be much more convenient if the loop over pages happened in the template, allowing me to just stick whatever markup I want around the loop.
+
+> Unfortunatly, I don't think this can be changed at this point,
+> it would probably break a lot of stuff that relies on the current
+> template arrangement, both in ikiwiki's internals and in
+> people's own, customised inline templates. (Also, I have some plans
+> to allow a single inline to use different templates for different
+> sorts of pages, which would rely on the current one template per
+> page approach to work.)
+> 
+> But there is a simple workaround.. the first template in
+> an inline has FIRST set, and the last one has LAST set.
+> So you can use that to emit your div or table top and bottom.
+> 
+> [[done]] --[[Joey]] 
diff --git a/doc/wikitemplates.mdwn b/doc/wikitemplates.mdwn
index f365cd5aa..6c0480cea 100644
--- a/doc/wikitemplates.mdwn
+++ b/doc/wikitemplates.mdwn
@@ -36,6 +36,8 @@ located in /usr/share/ikiwiki/templates by default.
   [[plugins/comments]] plugin.
 * `commentmoderation.tmpl` - This template is used to produce the comment
   moderation form.
+* `recentchanges.tmpl` - This template is used for listing a change
+  on the RecentChanges page.
 
 The [[plugins/pagetemplate]] plugin can allow individual pages to use a
 different template than `page.tmpl`.
-- 
cgit v1.2.3


From 3bbbe4b9df2c77fe55a017c79d1d0d6a96692400 Mon Sep 17 00:00:00 2001
From: Joey Hess <joey@gnu.kitenet.net>
Date: Fri, 22 May 2009 13:30:03 -0400
Subject: response

---
 doc/bugs/Insecure_dependency_in_mkdir.mdwn | 7 +++++++
 1 file changed, 7 insertions(+)

(limited to 'doc/bugs')

diff --git a/doc/bugs/Insecure_dependency_in_mkdir.mdwn b/doc/bugs/Insecure_dependency_in_mkdir.mdwn
index 5410ebbfd..46011a7e8 100644
--- a/doc/bugs/Insecure_dependency_in_mkdir.mdwn
+++ b/doc/bugs/Insecure_dependency_in_mkdir.mdwn
@@ -151,3 +151,10 @@ dubious
 >>>>>> You can check it out for yourself by pulling my fork of this, at github or my local repo.
 >>>>>> github will probably be faster for you: git://github.com/kjikaqawej/ikiwiki-simon.git --[[simonraven]]
 
+>>>>>>> I don't know what I'm supposed to see in your github tree.. it
+>>>>>>> looks identical to an old snapshot of ikiwiki's regular git repo?
+>>>>>>> If you want to put up the .deb you're using, I could examine that.
+>>>>>>>
+>>>>>>> I was in fact able to reproduce the insecure dependency in mkdir
+>>>>>>> message -- but only if I run 'perl -T ikiwiki'.
+>>>>>>> --[[Joey]] 
-- 
cgit v1.2.3


From 6ae08d3272355d21591d83a87d4e89c016eb5dc8 Mon Sep 17 00:00:00 2001
From: Joey Hess <joey@gnu.kitenet.net>
Date: Fri, 22 May 2009 15:24:42 -0400
Subject: add

---
 doc/bugs/aggregate_global_feed_names.mdwn | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 doc/bugs/aggregate_global_feed_names.mdwn

(limited to 'doc/bugs')

diff --git a/doc/bugs/aggregate_global_feed_names.mdwn b/doc/bugs/aggregate_global_feed_names.mdwn
new file mode 100644
index 000000000..27127ce27
--- /dev/null
+++ b/doc/bugs/aggregate_global_feed_names.mdwn
@@ -0,0 +1,13 @@
+[[plugins/aggregate]] takes a name parameter that specifies a global name
+for a feed. This causes some problems:
+
+* If a site has multiple pages that aggregate, and they use the same
+  name, one will win and get the global name, the other will claim it's
+  working, but it's really showing what the other aggregated.
+* If an aggregate directive is moved from page A to page B, and the wiki
+  refreshed, aggregate does not realize the feed moved, and so it will
+  keep aggregated pages under `A/feed_name/*`. To work around this bug,
+  you have to delete A, refresh (maybe with --aggregate?), and then add B.
+
+Need to find a way to not make the name be global. Perhaps it needs to
+include the name of the page that contains the directive?
-- 
cgit v1.2.3


From 8662d5920f56c185b0e0c5ebdac2a09f74c93eaf Mon Sep 17 00:00:00 2001
From: "http://lj.rossia.org/users/imz/" <http://lj.rossia.org/users/imz/@web>
Date: Tue, 26 May 2009 09:19:02 -0400
Subject: Report the unpleasant need to press "reload" in firefox.

---
 ...efox_doesn__39__t_want_to_load_updated_pages_at_ikiwiki.info.mdwn | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 doc/bugs/firefox_doesn__39__t_want_to_load_updated_pages_at_ikiwiki.info.mdwn

(limited to 'doc/bugs')

diff --git a/doc/bugs/firefox_doesn__39__t_want_to_load_updated_pages_at_ikiwiki.info.mdwn b/doc/bugs/firefox_doesn__39__t_want_to_load_updated_pages_at_ikiwiki.info.mdwn
new file mode 100644
index 000000000..8cb47f864
--- /dev/null
+++ b/doc/bugs/firefox_doesn__39__t_want_to_load_updated_pages_at_ikiwiki.info.mdwn
@@ -0,0 +1,5 @@
+I'm using firefox-3.0.8-alt0.M41.1 (Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.4pre) Gecko/2008100921 Firefox/3.0). I have noticed that quite often it shows an old state of a page at http://ikiwiki.info, e.g., [[recentchanges]] without my last edits, or the last page I edited (say, 50 min ago) in the state it was before I edited it.
+
+Only explicitly pressing "reload" helps.
+
+Is it a bug? I haven't been noticing such problems usually on other sites. --Ivan Z.
-- 
cgit v1.2.3


From 221f1bf624f27a470e44fd62c6256e37dc667c73 Mon Sep 17 00:00:00 2001
From: "http://lj.rossia.org/users/imz/" <http://lj.rossia.org/users/imz/@web>
Date: Tue, 26 May 2009 11:16:40 -0400
Subject: Comment: this illustrates there is no workaround.

---
 doc/bugs/tagged__40____41___matching_wikilinks.mdwn | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'doc/bugs')

diff --git a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
index 2b30f247e..86ed67252 100644
--- a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
+++ b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
@@ -27,3 +27,5 @@ rationale on this, or what am I doing wrong, and how to achieve what I want?
 >> No, he has no pages under tagbase that aren't tags. This bug
 >> is valid. [[todo/matching_different_kinds_of_links]] is probably
 >> how it will eventually be solved. --[[Joey]] 
+
+> And this is an illustration why a clean work-around (without changing the software) is not possible: while thinking about [[todo/matching_different_kinds_of_links], I thought one could work around the problem by simply explicitly including the kind of the relation into the link target (like the tagbase in tags), and by having a separate page without the "tagbase" to link to when one wants simply to refer to the tag without tagging. But this won't work: one has to at least once refer to the real tag page if one wants to talk about it, and this reference will count as tagging (unwanted). --Ivan Z.
-- 
cgit v1.2.3


From a783062c6edab3355d6ac87b5431d80256807b9f Mon Sep 17 00:00:00 2001
From: "http://lj.rossia.org/users/imz/" <http://lj.rossia.org/users/imz/@web>
Date: Tue, 26 May 2009 11:25:33 -0400
Subject: A workaround without introducing different kinds of links (but with
 completely auxiliary link targets).

---
 doc/bugs/tagged__40____41___matching_wikilinks.mdwn | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'doc/bugs')

diff --git a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
index 86ed67252..e7e4af7c3 100644
--- a/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
+++ b/doc/bugs/tagged__40____41___matching_wikilinks.mdwn
@@ -28,4 +28,6 @@ rationale on this, or what am I doing wrong, and how to achieve what I want?
 >> is valid. [[todo/matching_different_kinds_of_links]] is probably
 >> how it will eventually be solved. --[[Joey]] 
 
-> And this is an illustration why a clean work-around (without changing the software) is not possible: while thinking about [[todo/matching_different_kinds_of_links], I thought one could work around the problem by simply explicitly including the kind of the relation into the link target (like the tagbase in tags), and by having a separate page without the "tagbase" to link to when one wants simply to refer to the tag without tagging. But this won't work: one has to at least once refer to the real tag page if one wants to talk about it, and this reference will count as tagging (unwanted). --Ivan Z.
+> And this is an illustration why a clean work-around (without changing the software) is not possible: while thinking about [[todo/matching_different_kinds_of_links]], I thought one could work around the problem by simply explicitly including the kind of the relation into the link target (like the tagbase in tags), and by having a separate page without the "tagbase" to link to when one wants simply to refer to the tag without tagging. But this won't work: one has to at least once refer to the real tag page if one wants to talk about it, and this reference will count as tagging (unwanted). --Ivan Z.
+
+> But well, perhaps there is a workaround without introducing different kinds of links. One could modify the [[tag plugin|plugins/tag]] so that it adds 2 links to a page: for tagging -- `tagbase/TAG`, and for navigation -- `tagdescription/TAG` (displayed at the bottom). Then the `tagdescription/TAG` page would hold whatever list one wishes (with `tagged(TAG)` in the pagespec), and whenever one wants to merely refer to the tag, one should link to `tagdescription/TAG`--this link won't count as tagging. So, `tagbase/TAG` would become completely auxiliary (internal) link targets for ikiwiki, the users would edit or link to only `tagdescription/TAG`. --Ivan Z.
-- 
cgit v1.2.3


From 392157083be1ae66cc02687709f56bb001c5cac3 Mon Sep 17 00:00:00 2001
From: "http://lj.rossia.org/users/imz/" <http://lj.rossia.org/users/imz/@web>
Date: Tue, 26 May 2009 11:57:12 -0400
Subject: A misfeature I stumbled upon.

---
 ...ode___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn | 9 +++++++++
 1 file changed, 9 insertions(+)
 create mode 100644 doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn

(limited to 'doc/bugs')

diff --git a/doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn b/doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn
new file mode 100644
index 000000000..8cfe8aca6
--- /dev/null
+++ b/doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn
@@ -0,0 +1,9 @@
+Example (from [](http://git.ikiwiki.info/?p=ikiwiki;a=blobdiff;f=doc/todo/matching_different_kinds_of_links.mdwn;h=26c5a072bf3cb205b238a4e6fd0882583a0b7609;hp=1d7c78d9065d78307b43a1f58a53300cde4015fa;hb=9b4c83127fdef0ceb682c104db9bfb321b17022e;hpb=df4cc4c16ca230ee99b80c80043ba54fb95f6e71)):
+<pre>
+\[[`\\[[!taglink TAG\\]\\]`|plugins/tag]]
+</pre>
+gives:
+
+[[`\[[!taglink TAG\]\]`|plugins/tag]]
+
+Expected: there is a wikilink with the complex text as the displayed text. --Ivan Z.
-- 
cgit v1.2.3


From 0e72550870ed51aa6aee57e08f63edf0b07befc0 Mon Sep 17 00:00:00 2001
From: "http://lj.rossia.org/users/imz/" <http://lj.rossia.org/users/imz/@web>
Date: Tue, 26 May 2009 11:59:36 -0400
Subject: minor: A text for a link, otherwise it's not displayed; also rm
 unneeded escaping.

---
 ...iki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'doc/bugs')

diff --git a/doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn b/doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn
index 8cfe8aca6..9827250e6 100644
--- a/doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn
+++ b/doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn
@@ -1,6 +1,6 @@
-Example (from [](http://git.ikiwiki.info/?p=ikiwiki;a=blobdiff;f=doc/todo/matching_different_kinds_of_links.mdwn;h=26c5a072bf3cb205b238a4e6fd0882583a0b7609;hp=1d7c78d9065d78307b43a1f58a53300cde4015fa;hb=9b4c83127fdef0ceb682c104db9bfb321b17022e;hpb=df4cc4c16ca230ee99b80c80043ba54fb95f6e71)):
+Example (from [here](http://git.ikiwiki.info/?p=ikiwiki;a=blobdiff;f=doc/todo/matching_different_kinds_of_links.mdwn;h=26c5a072bf3cb205b238a4e6fd0882583a0b7609;hp=1d7c78d9065d78307b43a1f58a53300cde4015fa;hb=9b4c83127fdef0ceb682c104db9bfb321b17022e;hpb=df4cc4c16ca230ee99b80c80043ba54fb95f6e71)):
 <pre>
-\[[`\\[[!taglink TAG\\]\\]`|plugins/tag]]
+[[`\[[!taglink TAG\]\]`|plugins/tag]]
 </pre>
 gives:
 
-- 
cgit v1.2.3


From 7d881b7e3444a4e15d8ae1e338728c389ab50b31 Mon Sep 17 00:00:00 2001
From: "http://lj.rossia.org/users/imz/" <http://lj.rossia.org/users/imz/@web>
Date: Tue, 26 May 2009 12:01:17 -0400
Subject: minor: Added a wikilink (for connectivity).

---
 ..._wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'doc/bugs')

diff --git a/doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn b/doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn
index 9827250e6..364fae394 100644
--- a/doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn
+++ b/doc/bugs/complex_wiki-code___40__braces__41___in_wikilink-text_breaks_wikilinks.mdwn
@@ -6,4 +6,4 @@ gives:
 
 [[`\[[!taglink TAG\]\]`|plugins/tag]]
 
-Expected: there is a wikilink with the complex text as the displayed text. --Ivan Z.
+Expected: there is a [[ikiwiki/wikilink]] with the complex text as the displayed text. --Ivan Z.
-- 
cgit v1.2.3


From 9470667a0dcb27a6dcdf51657b85c939ff708af3 Mon Sep 17 00:00:00 2001
From: intrigeri <intrigeri@web>
Date: Wed, 3 Jun 2009 12:09:29 -0400
Subject: new bug and patch

---
 ...anted_discussion_links_on_discussion_pages.mdwn | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 doc/bugs/unwanted_discussion_links_on_discussion_pages.mdwn

(limited to 'doc/bugs')

diff --git a/doc/bugs/unwanted_discussion_links_on_discussion_pages.mdwn b/doc/bugs/unwanted_discussion_links_on_discussion_pages.mdwn
new file mode 100644
index 000000000..c7506c6de
--- /dev/null
+++ b/doc/bugs/unwanted_discussion_links_on_discussion_pages.mdwn
@@ -0,0 +1,34 @@
+Background: some po translations (amongst which `fr.po`) translate "discussion" to an upper-cased word (in French: "Discussion").
+By the way, this is wished e.g. in German, where such a noun has to be written with an upper-cased "D", but I can not see
+the logic behind the added "D" in French.
+
+Anyway, this gettext-translated word is used to name the discussion pages, as `$discussionlink` in `Render.pm` is
+built from `gettext("discussion")`. In the same piece of code, a case-sensitive regexp that tests wether the page
+being rendered is a discussion page is case-sensitive.
+
+On the other hand, new discussion pages are created with a name built from `gettext("Discussion")` (please note the upper-cased
+"D"). Such a new page name seems to be automagically downcased.
+
+This leads to newly created discussion pages not being recognized as discussion pages by the
+`$page !~ /.*\/\Q$discussionlink\E$/` regexp, so that then end with an unwanted discussion link.
+
+A simple fix that seems to work is to make this regexp case-insensitive:
+
+    git diff IkiWiki/Render.pm
+    diff --git a/IkiWiki/Render.pm b/IkiWiki/Render.pm
+    index adae9f0..093c25b 100644
+    --- a/IkiWiki/Render.pm
+    +++ b/IkiWiki/Render.pm
+    @@ -77,7 +77,7 @@ sub genpage ($$) {
+            }
+            if ($config{discussion}) {
+                    my $discussionlink=gettext("discussion");
+    -               if ($page !~ /.*\/\Q$discussionlink\E$/ &&
+    +               if ($page !~ /.*\/\Q$discussionlink\E$/i &&
+                       (length $config{cgiurl} ||
+                        exists $links{$page."/".$discussionlink})) {
+                            $template->param(discussionlink => htmllink($page, $page, gettext("Discussion"), noimageinline => 1, forcesubpage => 1));
+
+But the best way would be to avoid assuming implicitely that translators will translate "discussion" and "Discussion" the same way.
+
+[[!tag patch]]
-- 
cgit v1.2.3


From 296554daaf771d64e76355638aec986a3b22e421 Mon Sep 17 00:00:00 2001
From: "http://smcv.pseudorandom.co.uk/" <http://smcv.pseudorandom.co.uk/@web>
Date: Wed, 3 Jun 2009 14:21:40 -0400
Subject:

---
 doc/bugs/support_for_openid2_logins.mdwn | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'doc/bugs')

diff --git a/doc/bugs/support_for_openid2_logins.mdwn b/doc/bugs/support_for_openid2_logins.mdwn
index f78d50c3c..bc48808fd 100644
--- a/doc/bugs/support_for_openid2_logins.mdwn
+++ b/doc/bugs/support_for_openid2_logins.mdwn
@@ -8,3 +8,6 @@ I've contacted JanRain who have pointed me to:
 * Some [work](http://code.sixapart.com/svn/openid/trunk/perl/) by David Recordon
 
 However both Perl OpenID 2.x implementations have not been released and are incomplete implementations. :(
+
+> Net::OpenID::Consumer 0.x in Debian is only an OpenID 1 implementation. However,
+> Net::OpenID::Consumer 1.x claims to be an OpenID 2 implementation. --[[smcv]]
-- 
cgit v1.2.3


From 25aa050305b3e788e9287163bfa7f59d15aa747b Mon Sep 17 00:00:00 2001
From: "http://smcv.pseudorandom.co.uk/" <http://smcv.pseudorandom.co.uk/@web>
Date: Wed, 3 Jun 2009 14:28:21 -0400
Subject: fixed upstream, debian bug opened

---
 doc/bugs/support_for_openid2_logins.mdwn | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

(limited to 'doc/bugs')

diff --git a/doc/bugs/support_for_openid2_logins.mdwn b/doc/bugs/support_for_openid2_logins.mdwn
index bc48808fd..1d99370f6 100644
--- a/doc/bugs/support_for_openid2_logins.mdwn
+++ b/doc/bugs/support_for_openid2_logins.mdwn
@@ -9,5 +9,9 @@ I've contacted JanRain who have pointed me to:
 
 However both Perl OpenID 2.x implementations have not been released and are incomplete implementations. :(
 
-> Net::OpenID::Consumer 0.x in Debian is only an OpenID 1 implementation. However,
-> Net::OpenID::Consumer 1.x claims to be an OpenID 2 implementation. --[[smcv]]
+> Both of the projects referenced above have since been released.
+> Net::OpenID::Consumer 0.x in Debian is indeed only an OpenID 1
+> implementation. However, Net::OpenID::Consumer 1.x claims to be
+> an OpenID 2 implementation (it's the second of the projects
+> above). I've filed a bug in Debian asking for the package to be
+> updated. --[[smcv]]
-- 
cgit v1.2.3


From 6842328405494dd4971d3bfa443901084efe87ed Mon Sep 17 00:00:00 2001
From: Joey Hess <joey@gnu.kitenet.net>
Date: Thu, 4 Jun 2009 13:15:05 -0400
Subject: Avoid relying on translators preserving the case when translating
 "discussion", which caused Discussion pages to get unwanted Discussion links.

---
 IkiWiki/Render.pm                                           | 2 +-
 debian/changelog                                            | 3 +++
 doc/bugs/unwanted_discussion_links_on_discussion_pages.mdwn | 2 ++
 3 files changed, 6 insertions(+), 1 deletion(-)

(limited to 'doc/bugs')

diff --git a/IkiWiki/Render.pm b/IkiWiki/Render.pm
index adae9f0d5..ba1d1eae5 100644
--- a/IkiWiki/Render.pm
+++ b/IkiWiki/Render.pm
@@ -76,7 +76,7 @@ sub genpage ($$) {
 		$actions++;
 	}
 	if ($config{discussion}) {
-		my $discussionlink=gettext("discussion");
+		my $discussionlink=lc(gettext("Discussion"));
 		if ($page !~ /.*\/\Q$discussionlink\E$/ &&
 		   (length $config{cgiurl} ||
 		    exists $links{$page."/".$discussionlink})) {
diff --git a/debian/changelog b/debian/changelog
index cee073b3a..be1db6f3c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,9 @@ ikiwiki (3.15) UNRELEASED; urgency=low
 
   * comment: Make comment directives no longer use the internal "_comment"
     form, and document the comment directive syntax.
+  * Avoid relying on translators preserving the case when translating
+    "discussion", which caused Discussion pages to get unwanted Discussion
+    links.
 
  -- Joey Hess <joeyh@debian.org>  Tue, 02 Jun 2009 17:03:41 -0400
 
diff --git a/doc/bugs/unwanted_discussion_links_on_discussion_pages.mdwn b/doc/bugs/unwanted_discussion_links_on_discussion_pages.mdwn
index c7506c6de..c74a094ce 100644
--- a/doc/bugs/unwanted_discussion_links_on_discussion_pages.mdwn
+++ b/doc/bugs/unwanted_discussion_links_on_discussion_pages.mdwn
@@ -31,4 +31,6 @@ A simple fix that seems to work is to make this regexp case-insensitive:
 
 But the best way would be to avoid assuming implicitely that translators will translate "discussion" and "Discussion" the same way.
 
+> [[done]] --[[Joey]] 
+
 [[!tag patch]]
-- 
cgit v1.2.3


From c873dd03b8ee390e2e036c98fcf0748da39e35be Mon Sep 17 00:00:00 2001
From: "http://lj.rossia.org/users/imz/" <http://lj.rossia.org/users/imz/@web>
Date: Fri, 5 Jun 2009 14:37:14 -0400
Subject: Report the failed test of the "more" plugin.

---
 doc/bugs/__34__more__34___doesn__39__t_work.mdwn | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 doc/bugs/__34__more__34___doesn__39__t_work.mdwn

(limited to 'doc/bugs')

diff --git a/doc/bugs/__34__more__34___doesn__39__t_work.mdwn b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
new file mode 100644
index 000000000..5a501fe0e
--- /dev/null
+++ b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
@@ -0,0 +1,10 @@
+As one can see at [[plugins/more/discussion]], the [[plugins/more]] doesn't work --- it renders as:
+
+  <p><a name="more"></a></p>
+  
+  <p>This is the rest of my post. Not intended for people catching up on
+  their blogs at 30,000 feet. Because I like to make things
+  difficult.</p>
+
+No way to toggle visibility.
+-- Ivan Z.
-- 
cgit v1.2.3


From 08b5581b92277faaad95ff4ecf187be9bafef3bc Mon Sep 17 00:00:00 2001
From: "http://lj.rossia.org/users/imz/" <http://lj.rossia.org/users/imz/@web>
Date: Fri, 5 Jun 2009 14:38:49 -0400
Subject: minor: Formatting the code.

---
 doc/bugs/__34__more__34___doesn__39__t_work.mdwn | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

(limited to 'doc/bugs')

diff --git a/doc/bugs/__34__more__34___doesn__39__t_work.mdwn b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
index 5a501fe0e..731d6a3bb 100644
--- a/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
+++ b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
@@ -1,10 +1,10 @@
 As one can see at [[plugins/more/discussion]], the [[plugins/more]] doesn't work --- it renders as:
 
-  <p><a name="more"></a></p>
-  
-  <p>This is the rest of my post. Not intended for people catching up on
-  their blogs at 30,000 feet. Because I like to make things
-  difficult.</p>
+    <p><a name="more"></a></p>
+    
+    <p>This is the rest of my post. Not intended for people catching up on
+    their blogs at 30,000 feet. Because I like to make things
+    difficult.</p>
 
 No way to toggle visibility.
 -- Ivan Z.
-- 
cgit v1.2.3


From 7158fab372e94bfd8f1cd7d16756b80df55d876a Mon Sep 17 00:00:00 2001
From: "http://lj.rossia.org/users/imz/" <http://lj.rossia.org/users/imz/@web>
Date: Fri, 5 Jun 2009 14:41:05 -0400
Subject: minor: Style.

---
 doc/bugs/__34__more__34___doesn__39__t_work.mdwn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'doc/bugs')

diff --git a/doc/bugs/__34__more__34___doesn__39__t_work.mdwn b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
index 731d6a3bb..fbe285485 100644
--- a/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
+++ b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
@@ -1,4 +1,4 @@
-As one can see at [[plugins/more/discussion]], the [[plugins/more]] doesn't work --- it renders as:
+As one can see at [[plugins/more/discussion]], the [[plugins/more]] plugin doesn't work --- it renders as:
 
     <p><a name="more"></a></p>
     
-- 
cgit v1.2.3


From 1d57a21c987a5e970df01efe10acdf69982c2d61 Mon Sep 17 00:00:00 2001
From: Joey Hess <joey@gnu.kitenet.net>
Date: Fri, 5 Jun 2009 15:04:49 -0400
Subject: close

---
 doc/bugs/__34__more__34___doesn__39__t_work.mdwn | 5 +++++
 1 file changed, 5 insertions(+)

(limited to 'doc/bugs')

diff --git a/doc/bugs/__34__more__34___doesn__39__t_work.mdwn b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
index fbe285485..45757f9e4 100644
--- a/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
+++ b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
@@ -8,3 +8,8 @@ As one can see at [[plugins/more/discussion]], the [[plugins/more]] plugin doesn
 
 No way to toggle visibility.
 -- Ivan Z.
+
+> More is not about toggling visibility. Perhaps you want
+> [[ikiwiki/plugins/toggle]]? More is about displaying the whole page
+> content when it's a standalone page, and only displaying a fragment when
+> it's inlined into a blog. --[[Joey]] [[done]]
-- 
cgit v1.2.3


From e8bd089583597539e37bdf1634741f2686947490 Mon Sep 17 00:00:00 2001
From: "http://lj.rossia.org/users/imz/" <http://lj.rossia.org/users/imz/@web>
Date: Fri, 5 Jun 2009 16:38:13 -0400
Subject: thanks.

---
 doc/bugs/__34__more__34___doesn__39__t_work.mdwn | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'doc/bugs')

diff --git a/doc/bugs/__34__more__34___doesn__39__t_work.mdwn b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
index 45757f9e4..e354e503a 100644
--- a/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
+++ b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
@@ -13,3 +13,5 @@ No way to toggle visibility.
 > [[ikiwiki/plugins/toggle]]? More is about displaying the whole page
 > content when it's a standalone page, and only displaying a fragment when
 > it's inlined into a blog. --[[Joey]] [[done]]
+
+>> I see, thanks for bothering with the reply, I didn't understand this. --Ivan Z.
-- 
cgit v1.2.3


From e27aaf967c52eac70452911d6623defcaa95ddf7 Mon Sep 17 00:00:00 2001
From: martin <martin@web>
Date: Fri, 5 Jun 2009 17:50:43 -0400
Subject: pagecount incorrectly claims there are 0 pages ...

---
 doc/bugs/pagecount_is_broken.mdwn | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 doc/bugs/pagecount_is_broken.mdwn

(limited to 'doc/bugs')

diff --git a/doc/bugs/pagecount_is_broken.mdwn b/doc/bugs/pagecount_is_broken.mdwn
new file mode 100644
index 000000000..179981855
--- /dev/null
+++ b/doc/bugs/pagecount_is_broken.mdwn
@@ -0,0 +1 @@
+The [[plugins/pagecount]] plugin seems to be broken, as it claims there are [[!pagecount ]] pages in this wiki. (if it's not 0, the bug is fixed)
-- 
cgit v1.2.3


From 8d7488823582d63948a856222f275a01ac1939a2 Mon Sep 17 00:00:00 2001
From: martin <martin@web>
Date: Fri, 5 Jun 2009 17:52:54 -0400
Subject: fixed link

---
 doc/bugs/__34__more__34___doesn__39__t_work.mdwn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'doc/bugs')

diff --git a/doc/bugs/__34__more__34___doesn__39__t_work.mdwn b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
index e354e503a..b2d929f13 100644
--- a/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
+++ b/doc/bugs/__34__more__34___doesn__39__t_work.mdwn
@@ -10,7 +10,7 @@ No way to toggle visibility.
 -- Ivan Z.
 
 > More is not about toggling visibility. Perhaps you want
-> [[ikiwiki/plugins/toggle]]? More is about displaying the whole page
+> [[plugins/toggle]] More is about displaying the whole page
 > content when it's a standalone page, and only displaying a fragment when
 > it's inlined into a blog. --[[Joey]] [[done]]
 
-- 
cgit v1.2.3


From e8d8386e5258c055f253b20ad717461972b11c7d Mon Sep 17 00:00:00 2001
From: Joey Hess <joey@gnu.kitenet.net>
Date: Fri, 5 Jun 2009 18:04:39 -0400
Subject: pagecount: Fix broken optimisation for * pagespec.

---
 IkiWiki/Plugin/pagecount.pm       | 9 +++++++--
 debian/changelog                  | 1 +
 doc/bugs/pagecount_is_broken.mdwn | 2 ++
 3 files changed, 10 insertions(+), 2 deletions(-)

(limited to 'doc/bugs')

diff --git a/IkiWiki/Plugin/pagecount.pm b/IkiWiki/Plugin/pagecount.pm
index 1955603b0..5a2301af4 100644
--- a/IkiWiki/Plugin/pagecount.pm
+++ b/IkiWiki/Plugin/pagecount.pm
@@ -26,8 +26,13 @@ sub preprocess (@) {
 	# register a dependency.
 	add_depends($params{page}, $params{pages});
 	
-	my @pages=pagespec_match_list([keys %pagesources], $params{pages}, location => $params{page})
-		if $params{pages} ne "*"; # optimisation;
+	my @pages;
+	if ($params{pages} eq "*") {
+		@pages=keys %pagesources;
+	}
+	else {
+		@pages=pagespec_match_list([keys %pagesources], $params{pages}, location => $params{page});
+	}
 	return $#pages+1;
 }
 
diff --git a/debian/changelog b/debian/changelog
index 7d0fb5c80..df4429326 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -13,6 +13,7 @@ ikiwiki (3.15) UNRELEASED; urgency=low
     setup file can be loaded and that its config is ok. If a plugin
     fails for any reason, disable it in the generated file.
     Closes: 532001
+  * pagecount: Fix broken optimisation for * pagespec.
 
  -- Joey Hess <joeyh@debian.org>  Tue, 02 Jun 2009 17:03:41 -0400
 
diff --git a/doc/bugs/pagecount_is_broken.mdwn b/doc/bugs/pagecount_is_broken.mdwn
index 179981855..101230d94 100644
--- a/doc/bugs/pagecount_is_broken.mdwn
+++ b/doc/bugs/pagecount_is_broken.mdwn
@@ -1 +1,3 @@
 The [[plugins/pagecount]] plugin seems to be broken, as it claims there are [[!pagecount ]] pages in this wiki. (if it's not 0, the bug is fixed)
+
+[[fixed|done]] --[[Joey]] 
-- 
cgit v1.2.3


From 07b61ec8b6994fac49ba5f0e22397e8fb143bf87 Mon Sep 17 00:00:00 2001
From: Joey Hess <joey@gnu.kitenet.net>
Date: Sat, 6 Jun 2009 02:25:25 -0400
Subject: add

---
 doc/bugs/goto_with_bad_page_name.mdwn | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 doc/bugs/goto_with_bad_page_name.mdwn

(limited to 'doc/bugs')

diff --git a/doc/bugs/goto_with_bad_page_name.mdwn b/doc/bugs/goto_with_bad_page_name.mdwn
new file mode 100644
index 000000000..722c4e266
--- /dev/null
+++ b/doc/bugs/goto_with_bad_page_name.mdwn
@@ -0,0 +1,23 @@
+If goto is passed a page name that 
+contains spaces or is otherwise not a valid page name,
+it will display a "page does not exist", with a create link. But,
+clicking on the link will result in "bad page name".
+
+I have found at least two ways it can happen:
+
+* If 404 is enabled, and the user goes to "http://wiki/some page with spaces"
+* If mercurial is used, it pulls the user's full name, with spaces,
+  out for `rcs_recentchanges` and that ends up on RecentChanges.
+
+When fixing, need to keep in mind that we can't just run the input through
+titlepage, since in all other circumstances, the page name is already valid
+and we don't want to doubly-encode it.
+
+Seems like the goto plugin needs to check if the page name is valid and
+pass it through titlepage if not.
+
+(As a side effect of this, 404 will start redirecting "http://wiki/some page
+with spaces" to "http://wiki/some_page_with_spaces", if the latter exists.
+That seems like a fairly good thing.)
+
+--[[Joey]] 
-- 
cgit v1.2.3


From e40d2a6b2b1bdf677f11cc4a71595acf609d1e75 Mon Sep 17 00:00:00 2001
From: Joey Hess <joey@gnu.kitenet.net>
Date: Sat, 6 Jun 2009 02:36:40 -0400
Subject: goto: Support being passed a page title that is not a valid page
 name, to support several cases including mercurial's long user names on the
 RecentChanges page, and urls with spaces being handled by the 404 plugin.

---
 IkiWiki/Plugin/goto.pm                | 6 ++++++
 debian/changelog                      | 4 ++++
 doc/bugs/goto_with_bad_page_name.mdwn | 2 ++
 3 files changed, 12 insertions(+)

(limited to 'doc/bugs')

diff --git a/IkiWiki/Plugin/goto.pm b/IkiWiki/Plugin/goto.pm
index 3f40c5859..2e2dc04a1 100644
--- a/IkiWiki/Plugin/goto.pm
+++ b/IkiWiki/Plugin/goto.pm
@@ -32,6 +32,12 @@ sub cgi_goto ($;$) {
 		}
 	}
 
+	# It's possible that $page is not a valid page name;
+	# if so attempt to turn it into one.
+	if ($page !~ /$config{wiki_file_regexp}/) {
+		$page=titlepage($page);
+	}
+
 	IkiWiki::loadindex();
 
 	# If the page is internal (like a comment), see if it has a
diff --git a/debian/changelog b/debian/changelog
index df4429326..7f8257813 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,6 +14,10 @@ ikiwiki (3.15) UNRELEASED; urgency=low
     fails for any reason, disable it in the generated file.
     Closes: 532001
   * pagecount: Fix broken optimisation for * pagespec.
+  * goto: Support being passed a page title that is not a valid page
+    name, to support several cases including mercurial's long user
+    names on the RecentChanges page, and urls with spaces being handled
+    by the 404 plugin.
 
  -- Joey Hess <joeyh@debian.org>  Tue, 02 Jun 2009 17:03:41 -0400
 
diff --git a/doc/bugs/goto_with_bad_page_name.mdwn b/doc/bugs/goto_with_bad_page_name.mdwn
index 722c4e266..bc462c840 100644
--- a/doc/bugs/goto_with_bad_page_name.mdwn
+++ b/doc/bugs/goto_with_bad_page_name.mdwn
@@ -20,4 +20,6 @@ pass it through titlepage if not.
 with spaces" to "http://wiki/some_page_with_spaces", if the latter exists.
 That seems like a fairly good thing.)
 
+[[done]]
+
 --[[Joey]] 
-- 
cgit v1.2.3