From 64ca9a921a537baaed8cead9923f24f267f1040a Mon Sep 17 00:00:00 2001 From: joey Date: Tue, 30 Jan 2007 07:21:06 +0000 Subject: * Fix openid signin secret generation code. This fixes the bug that made all openid signins fail the first time, and then succeed the second time. --- doc/bugs/Error:_OpenID_failure:_time_bad_sig:.mdwn | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'doc/bugs') diff --git a/doc/bugs/Error:_OpenID_failure:_time_bad_sig:.mdwn b/doc/bugs/Error:_OpenID_failure:_time_bad_sig:.mdwn index 8b011c22a..f65b572fc 100644 --- a/doc/bugs/Error:_OpenID_failure:_time_bad_sig:.mdwn +++ b/doc/bugs/Error:_OpenID_failure:_time_bad_sig:.mdwn @@ -25,7 +25,7 @@ ikiwiki or my OpenID servers. --Pawel my ($sig_time, $sig) = split(/\-/, $self->args("oic.time") || ""); # complain if more than an hour since we sent them off return $self->_fail("time_expired") if $sig_time < $now - 3600; - # also complain if the signature is from the future by more than 30 seconds, + also complain if the signature is from the future by more than 30 seconds, # which compensates for potential clock drift between nodes in a web farm. return $self->_fail("time_in_future") if $sig_time - 30 > $now; # and check that the time isn't faked @@ -40,4 +40,7 @@ ikiwiki or my OpenID servers. --Pawel I've had this problem too, but with my track record of reporting OpenID bugs I thought it best if I held my tongue. I usually experience this the first time I sign in on any ikiwiki installation of {ikiwiki.kitenet, ikidev, -betacantrips}, and I think re-logging in always works. --Ethan \ No newline at end of file +betacantrips}, and I think re-logging in always works. --Ethan + +> Does seem easier to repro than I thought. +> Ok, fixed it.. [[bugs/done]] --[[Joey]] -- cgit v1.2.3