From 06641bb8809775dae7ba7fb0817a45e067501ee2 Mon Sep 17 00:00:00 2001 From: "http://liw.fi/" Date: Mon, 2 Aug 2010 18:35:07 +0000 Subject: --- .../__34__First_post__34___deletion_does_not_refresh_front_page.mdwn | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn (limited to 'doc/bugs') diff --git a/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn b/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn new file mode 100644 index 000000000..8d04ed18f --- /dev/null +++ b/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn @@ -0,0 +1,3 @@ +When I created an ikiwiki site (on Branchable) using the blog template, it added a "First post", which was fine. +Deleting that post removed it, but the front page did not get the re-generated, so it was still there. +--[[liw]] -- cgit v1.2.3 From d934cee673ee18cd814e658a86c607fe5a209476 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 2 Aug 2010 14:37:02 -0400 Subject: resp --- .../__34__First_post__34___deletion_does_not_refresh_front_page.mdwn | 3 +++ 1 file changed, 3 insertions(+) (limited to 'doc/bugs') diff --git a/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn b/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn index 8d04ed18f..d605aa8d4 100644 --- a/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn +++ b/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn @@ -1,3 +1,6 @@ When I created an ikiwiki site (on Branchable) using the blog template, it added a "First post", which was fine. Deleting that post removed it, but the front page did not get the re-generated, so it was still there. --[[liw]] + +> From a quick look, it seems that `depends_simple` does not contain pages +> in the inline. Need to investigate further. --[[Joey]] -- cgit v1.2.3 From c2f2349de4507c8f7bb12926c3c49c917fcf2a06 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 4 Aug 2010 08:09:11 -0400 Subject: bug isolated --- .../__34__First_post__34___deletion_does_not_refresh_front_page.mdwn | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'doc/bugs') diff --git a/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn b/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn index d605aa8d4..78009da75 100644 --- a/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn +++ b/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn @@ -2,5 +2,5 @@ When I created an ikiwiki site (on Branchable) using the blog template, it added Deleting that post removed it, but the front page did not get the re-generated, so it was still there. --[[liw]] -> From a quick look, it seems that `depends_simple` does not contain pages -> in the inline. Need to investigate further. --[[Joey]] +> This is a bug involving the `page()` pagespec. Deleted +> pages matching this pagespec are not noticed. --[[Joey]] -- cgit v1.2.3 From 5d88146861ac237ac89cbed2e90a985b9c3bfdc2 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 4 Aug 2010 08:24:47 -0400 Subject: Fixes a bug that prevented matching deleted pages when using the page() PageSpec. --- IkiWiki.pm | 15 +++++++++------ debian/changelog | 2 ++ ...t_post__34___deletion_does_not_refresh_front_page.mdwn | 2 +- 3 files changed, 12 insertions(+), 7 deletions(-) (limited to 'doc/bugs') diff --git a/IkiWiki.pm b/IkiWiki.pm index e08d02922..df8abe2c2 100644 --- a/IkiWiki.pm +++ b/IkiWiki.pm @@ -2439,13 +2439,16 @@ sub match_internal ($$;@) { sub match_page ($$;@) { my $page=shift; my $match=match_glob($page, shift, @_); - if ($match && ! (exists $IkiWiki::pagesources{$page} - && defined IkiWiki::pagetype($IkiWiki::pagesources{$page}))) { - return IkiWiki::FailReason->new("$page is not a page"); - } - else { - return $match; + if ($match) { + my $source=exists $IkiWiki::pagesources{$page} ? + $IkiWiki::pagesources{$page} : + $IkiWiki::delpagesources{$page}; + my $type=defined $source ? IkiWiki::pagetype($source) : undef; + if (! defined $type) { + return IkiWiki::FailReason->new("$page is not a page"); + } } + return $match; } sub match_link ($$;@) { diff --git a/debian/changelog b/debian/changelog index 25123cecc..5c0064845 100644 --- a/debian/changelog +++ b/debian/changelog @@ -10,6 +10,8 @@ ikiwiki (3.20100723) UNRELEASED; urgency=low have been disabled. * Use Digest::SHA built into perl rather than external Digest::SHA1 to simplify dependencies. Closes: #591040 + * Fixes a bug that prevented matching deleted pages when using the page() + PageSpec. -- Joey Hess Fri, 23 Jul 2010 14:00:32 -0400 diff --git a/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn b/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn index 78009da75..2367335a7 100644 --- a/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn +++ b/doc/bugs/__34__First_post__34___deletion_does_not_refresh_front_page.mdwn @@ -3,4 +3,4 @@ Deleting that post removed it, but the front page did not get the re-generated, --[[liw]] > This is a bug involving the `page()` pagespec. Deleted -> pages matching this pagespec are not noticed. --[[Joey]] +> pages matching this pagespec are not noticed. --[[Joey]] [[done]] -- cgit v1.2.3 From 4e8a695431489d2059907122a11089c0e45a165c Mon Sep 17 00:00:00 2001 From: philippe Date: Sun, 15 Aug 2010 08:58:52 +0000 Subject: --- doc/bugs/po:_po_files_instead_of_html_files.mdwn | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 doc/bugs/po:_po_files_instead_of_html_files.mdwn (limited to 'doc/bugs') diff --git a/doc/bugs/po:_po_files_instead_of_html_files.mdwn b/doc/bugs/po:_po_files_instead_of_html_files.mdwn new file mode 100644 index 000000000..4b08c7c70 --- /dev/null +++ b/doc/bugs/po:_po_files_instead_of_html_files.mdwn @@ -0,0 +1,4 @@ +On the home page of my wiki, when i click on the link "ikiwiki", i get the english file instead of the french file. +At the bottom of this page, there is the "Links" line: +Links: index index.fr templates templates.fr +When i click on "templates.fr", i get the po.file instead of html. -- cgit v1.2.3 From 40fcc3868c0521704e465fc22e44f4c71dd85b86 Mon Sep 17 00:00:00 2001 From: "http://oblomov.myopenid.com/" Date: Tue, 17 Aug 2010 07:35:18 +0000 Subject: patch to provide relative font sizes in default CSS --- doc/bugs/absolute_sizes_in_default_CSS.mdwn | 37 +++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 doc/bugs/absolute_sizes_in_default_CSS.mdwn (limited to 'doc/bugs') diff --git a/doc/bugs/absolute_sizes_in_default_CSS.mdwn b/doc/bugs/absolute_sizes_in_default_CSS.mdwn new file mode 100644 index 000000000..e2d4e611c --- /dev/null +++ b/doc/bugs/absolute_sizes_in_default_CSS.mdwn @@ -0,0 +1,37 @@ +While toying around with some font sizes on my persona ikiwiki I discovered that some font sizes in the default CSS are fixed rather than relative. Here's a git patch that replaces them with relative font sizes (assuming the default 12pt/16px base font size recommended by the W3C): + +
+From 01c14db255bbb727d8dd1e72c3f6f2f25f07e757 Mon Sep 17 00:00:00 2001
+From: Giuseppe Bilotta 
+Date: Tue, 17 Aug 2010 00:48:24 +0200
+Subject: [PATCH] Use relative font-sizes
+
+---
+ doc/style.css |    4 ++--
+ 1 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/doc/style.css b/doc/style.css
+index 66d962b..fa4b2a3 100644
+--- a/doc/style.css
++++ b/doc/style.css
+@@ -14,7 +14,7 @@ nav {
+ 
+ .header {
+ 	margin: 0;
+-	font-size: 22px;
++	font-size: 140%;
+ 	font-weight: bold;
+ 	line-height: 1em;
+ 	display: block;
+@@ -22,7 +22,7 @@ nav {
+ 
+ .inlineheader .author {
+ 	margin: 0;
+-	font-size: 18px;
++	font-size: 112%;
+ 	font-weight: bold;
+ 	display: block;
+ }
+-- 
+1.7.2.rc0.231.gc73d
+
-- cgit v1.2.3 From ed80e02c06c0838dcf205378e1dcaa5f1076c278 Mon Sep 17 00:00:00 2001 From: "http://oblomov.myopenid.com/" Date: Tue, 17 Aug 2010 07:37:01 +0000 Subject: forgot to escape the <> chars in the format-patch output --- doc/bugs/absolute_sizes_in_default_CSS.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc/bugs') diff --git a/doc/bugs/absolute_sizes_in_default_CSS.mdwn b/doc/bugs/absolute_sizes_in_default_CSS.mdwn index e2d4e611c..5cf70d6ee 100644 --- a/doc/bugs/absolute_sizes_in_default_CSS.mdwn +++ b/doc/bugs/absolute_sizes_in_default_CSS.mdwn @@ -2,7 +2,7 @@ While toying around with some font sizes on my persona ikiwiki I discovered that 
 From 01c14db255bbb727d8dd1e72c3f6f2f25f07e757 Mon Sep 17 00:00:00 2001
-From: Giuseppe Bilotta 
+From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
 Date: Tue, 17 Aug 2010 00:48:24 +0200
 Subject: [PATCH] Use relative font-sizes
 
-- 
cgit v1.2.3


From 20ecef4d024f751481645db3aa68d098e1251b19 Mon Sep 17 00:00:00 2001
From: Joey Hess 
Date: Tue, 17 Aug 2010 16:37:48 -0400
Subject: style.css: Use relative, not absolute font sizes. Thanks, Giuseppe
 Bilotta.

---
 debian/changelog                            | 1 +
 doc/bugs/absolute_sizes_in_default_CSS.mdwn | 2 ++
 doc/style.css                               | 4 ++--
 3 files changed, 5 insertions(+), 2 deletions(-)

(limited to 'doc/bugs')

diff --git a/debian/changelog b/debian/changelog
index cbd7e7254..8fee36b98 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,7 @@ ikiwiki (3.20100816) UNRELEASED; urgency=low
   * openid: Syntax tweak to the javascript code to make it work with MSIE 7
     (and MSIE 8 in compat mode). Thanks to Iain McLaren for reporting
     the bug and providing access to debug it.
+  * style.css: Use relative, not absolute font sizes. Thanks, Giuseppe Bilotta.
 
  -- Joey Hess   Sun, 15 Aug 2010 11:45:48 -0400
 
diff --git a/doc/bugs/absolute_sizes_in_default_CSS.mdwn b/doc/bugs/absolute_sizes_in_default_CSS.mdwn
index 5cf70d6ee..bb3c0c7a0 100644
--- a/doc/bugs/absolute_sizes_in_default_CSS.mdwn
+++ b/doc/bugs/absolute_sizes_in_default_CSS.mdwn
@@ -1,5 +1,7 @@
 While toying around with some font sizes on my persona ikiwiki I discovered that some font sizes in the default CSS are fixed rather than relative. Here's a git patch that replaces them with relative font sizes (assuming the default 12pt/16px base font size recommended by the W3C):
 
+[[done]] --[[Joey]] 
+
 
 From 01c14db255bbb727d8dd1e72c3f6f2f25f07e757 Mon Sep 17 00:00:00 2001
 From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
diff --git a/doc/style.css b/doc/style.css
index 66d962bd6..fa4b2a38a 100644
--- a/doc/style.css
+++ b/doc/style.css
@@ -14,7 +14,7 @@ nav {
 
 .header {
 	margin: 0;
-	font-size: 22px;
+	font-size: 140%;
 	font-weight: bold;
 	line-height: 1em;
 	display: block;
@@ -22,7 +22,7 @@ nav {
 
 .inlineheader .author {
 	margin: 0;
-	font-size: 18px;
+	font-size: 112%;
 	font-weight: bold;
 	display: block;
 }
-- 
cgit v1.2.3