From 354d22e27b4d9cb8207e038de4f342545435d2c6 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Thu, 30 Oct 2008 13:41:19 -0400 Subject: don't rely on plugin load order when determining generated directives Instead, shortcuts will explicitly be marked as such when registered, and listdirectives can filter them out. --- doc/bugs/cannot_preview_shortcuts.mdwn | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'doc/bugs') diff --git a/doc/bugs/cannot_preview_shortcuts.mdwn b/doc/bugs/cannot_preview_shortcuts.mdwn index 7c830898d..d7045b2dc 100644 --- a/doc/bugs/cannot_preview_shortcuts.mdwn +++ b/doc/bugs/cannot_preview_shortcuts.mdwn @@ -8,3 +8,10 @@ Shortcuts such as \[[!google foo]] do not work when previewing pages. >> still works, but it relies on the fact that the `listdirectives` `checkconfig` >> hook is called before the `shortcut` `checkconfig` hook. >> -- [[Will]] + +>> The order plugins are loaded is effectively random. (`keys %hooks`). +>> So I've made shortcuts pass a 'shortcut' parameter when registering +>> them, which listdirectives can grep out of the full list of directives. +>> That may not be the best name to give it, especially if other plugins +>> generate directives too. Seemed better than forcing shortcut's +>> checkconfig hook to run last tho. --[[Joey]] -- cgit v1.2.3