From 4ff60ef1c50ab182f7ce011de1ff7ca67e99254b Mon Sep 17 00:00:00 2001 From: joey Date: Sun, 28 Jan 2007 00:26:55 +0000 Subject: * Always call rcs_update after a commit during a web edit, to work around the problem described in bugs/svn_fails_to_update. Thanks to Ethan for the analysis and patch. --- doc/bugs/svn_fails_to_update.mdwn | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'doc/bugs/svn_fails_to_update.mdwn') diff --git a/doc/bugs/svn_fails_to_update.mdwn b/doc/bugs/svn_fails_to_update.mdwn index 015ab5a2b..6ed839cf6 100644 --- a/doc/bugs/svn_fails_to_update.mdwn +++ b/doc/bugs/svn_fails_to_update.mdwn @@ -76,4 +76,14 @@ Hmm, turns out that isn't the case! svn's prepedit function calls svn info which gets the "right" information even when the WC isn't current. I am having problems merging but that probably has nothing to do with this bug. [This patch](http://ikidev.betacantrips.com/patches/update.patch) calls -rcs_update after commit in CGI.pm, it might be a good idea anyhow. --Ethan \ No newline at end of file +rcs_update after commit in CGI.pm, it might be a good idea anyhow. --Ethan + +> Ok, I follow you. I am unsure whether this problem effects other rcses +> besides svn. Depends on how they handle locking, etc. But calling +> rcs_update will always be safe, so I'll do that. [[bugs/done]] +> +> That still leaves the issue that it calls svn update in the post-commit +> hook when it's locked and fails with that error message. Granted svn does +> throw that away by default, but it's still ugly and wasteful. But +> checking for a lock first is even uglier (and racey) and more wasteful, +> so I don't see a fix.. --[[Joey]] -- cgit v1.2.3