From bc0eec4633828e69f0c03a5c3befbf34898deba3 Mon Sep 17 00:00:00 2001 From: j-ali Date: Tue, 4 Aug 2009 05:28:45 -0400 Subject: --- doc/bugs/post-commit_hangs.mdwn | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/bugs/post-commit_hangs.mdwn (limited to 'doc/bugs/post-commit_hangs.mdwn') diff --git a/doc/bugs/post-commit_hangs.mdwn b/doc/bugs/post-commit_hangs.mdwn new file mode 100644 index 000000000..d6ea841ff --- /dev/null +++ b/doc/bugs/post-commit_hangs.mdwn @@ -0,0 +1 @@ +I installed ikiwiki v3.14159 in /usr/local from tarball (/usr contains an older version). Having done so, and used ikiwiki-transition to update setup file, the post commit hook is now blocking in flock (as seen by ps). I should also mention that I added the goodstuff, attachment and remove plugins (which was the purpose of upgrading to v3). Any clues as how to debug/fix gratefully received. The wiki is publically viewable at wiki.sgcm.org.uk if that helps. -- cgit v1.2.3 From c3a66316e0e44921439d98258f945a2fd2d679ca Mon Sep 17 00:00:00 2001 From: j-ali Date: Tue, 4 Aug 2009 05:41:07 -0400 Subject: --- doc/bugs/post-commit_hangs.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/bugs/post-commit_hangs.mdwn') diff --git a/doc/bugs/post-commit_hangs.mdwn b/doc/bugs/post-commit_hangs.mdwn index d6ea841ff..b6245bcd8 100644 --- a/doc/bugs/post-commit_hangs.mdwn +++ b/doc/bugs/post-commit_hangs.mdwn @@ -1 +1,3 @@ +# post-commit hangs + I installed ikiwiki v3.14159 in /usr/local from tarball (/usr contains an older version). Having done so, and used ikiwiki-transition to update setup file, the post commit hook is now blocking in flock (as seen by ps). I should also mention that I added the goodstuff, attachment and remove plugins (which was the purpose of upgrading to v3). Any clues as how to debug/fix gratefully received. The wiki is publically viewable at wiki.sgcm.org.uk if that helps. -- cgit v1.2.3 From a3959743b6b4e1b143d227aef8508f1606a59cff Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 4 Aug 2009 13:37:14 -0400 Subject: more info needed --- doc/bugs/post-commit_hangs.mdwn | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'doc/bugs/post-commit_hangs.mdwn') diff --git a/doc/bugs/post-commit_hangs.mdwn b/doc/bugs/post-commit_hangs.mdwn index b6245bcd8..a091446de 100644 --- a/doc/bugs/post-commit_hangs.mdwn +++ b/doc/bugs/post-commit_hangs.mdwn @@ -1,3 +1,7 @@ # post-commit hangs I installed ikiwiki v3.14159 in /usr/local from tarball (/usr contains an older version). Having done so, and used ikiwiki-transition to update setup file, the post commit hook is now blocking in flock (as seen by ps). I should also mention that I added the goodstuff, attachment and remove plugins (which was the purpose of upgrading to v3). Any clues as how to debug/fix gratefully received. The wiki is publically viewable at wiki.sgcm.org.uk if that helps. + +> It's blocking when you do what? Save a page from the web? Make a commit +> to the underlaying VCS? Which VCS? These are all different code paths.. +> --[[Joey]] -- cgit v1.2.3 From a7dae30074f2918893e23af103658a8594621158 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 4 Aug 2009 13:48:38 -0400 Subject: thought 2 --- doc/bugs/post-commit_hangs.mdwn | 3 +++ 1 file changed, 3 insertions(+) (limited to 'doc/bugs/post-commit_hangs.mdwn') diff --git a/doc/bugs/post-commit_hangs.mdwn b/doc/bugs/post-commit_hangs.mdwn index a091446de..af40a3cee 100644 --- a/doc/bugs/post-commit_hangs.mdwn +++ b/doc/bugs/post-commit_hangs.mdwn @@ -5,3 +5,6 @@ I installed ikiwiki v3.14159 in /usr/local from tarball (/usr contains an older > It's blocking when you do what? Save a page from the web? Make a commit > to the underlaying VCS? Which VCS? These are all different code paths.. > --[[Joey]] + +> Also, how have you arranged to keep it from seeing the installation in /usr? Perl could well be loading +> modules from the old installation, and if it's one with a different locking strategy that would explain your problem. --[[Joey]] -- cgit v1.2.3 From 3f33d3979c89610e1c8514c71c887acfa1c3ccac Mon Sep 17 00:00:00 2001 From: j-ali Date: Tue, 4 Aug 2009 16:18:49 -0400 Subject: --- doc/bugs/post-commit_hangs.mdwn | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'doc/bugs/post-commit_hangs.mdwn') diff --git a/doc/bugs/post-commit_hangs.mdwn b/doc/bugs/post-commit_hangs.mdwn index af40a3cee..c28a34040 100644 --- a/doc/bugs/post-commit_hangs.mdwn +++ b/doc/bugs/post-commit_hangs.mdwn @@ -6,5 +6,11 @@ I installed ikiwiki v3.14159 in /usr/local from tarball (/usr contains an older > to the underlaying VCS? Which VCS? These are all different code paths.. > --[[Joey]] +>> It's blocking when I run "ikiwiki --setup ikiwiki.setup" (which calls hg update, which calls ikiwiki --post-commit). +>> Hmm, maybe it's the recursive call to ikiwiki which is the problem. +>> The underlying VCS is mercurial. --Ali + > Also, how have you arranged to keep it from seeing the installation in /usr? Perl could well be loading > modules from the old installation, and if it's one with a different locking strategy that would explain your problem. --[[Joey]] + +>> Good point. Not knowing perl, I just assumed /usr/local would take precedence. I've now used "dpkg -r ikiwiki" to remove the problem. --Ali -- cgit v1.2.3 From a41d8177d4769daf20ea88baddedcc3cbcd56c21 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 4 Aug 2009 16:27:28 -0400 Subject: response --- doc/bugs/post-commit_hangs.mdwn | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'doc/bugs/post-commit_hangs.mdwn') diff --git a/doc/bugs/post-commit_hangs.mdwn b/doc/bugs/post-commit_hangs.mdwn index c28a34040..a19441b92 100644 --- a/doc/bugs/post-commit_hangs.mdwn +++ b/doc/bugs/post-commit_hangs.mdwn @@ -10,6 +10,16 @@ I installed ikiwiki v3.14159 in /usr/local from tarball (/usr contains an older >> Hmm, maybe it's the recursive call to ikiwiki which is the problem. >> The underlying VCS is mercurial. --Ali +>>> You're not supposed to run ikiwiki -setup manually in your post commit hook. +>>> Doing so will certianly lead to a locking problem; it also forces ikiwiki to rebuild +>>> the entire wiki anytime a single page changes, which is very inefficient! +>>> +>>> Instead, you should use the `mercurial_wrapper` setting +>>> in the setup file, which will make ikiwiki generate a small +>>> executable expressly designed to be run at post commit time. +>>> Or, you can use the `--post-commit` option, as documented +>>> in [[rcs/mecurial]] --[[Joey]] + > Also, how have you arranged to keep it from seeing the installation in /usr? Perl could well be loading > modules from the old installation, and if it's one with a different locking strategy that would explain your problem. --[[Joey]] -- cgit v1.2.3 From 7096ffaa529a0c26490770c5a882b0f96af8ecd2 Mon Sep 17 00:00:00 2001 From: j-ali Date: Tue, 4 Aug 2009 16:34:52 -0400 Subject: --- doc/bugs/post-commit_hangs.mdwn | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'doc/bugs/post-commit_hangs.mdwn') diff --git a/doc/bugs/post-commit_hangs.mdwn b/doc/bugs/post-commit_hangs.mdwn index a19441b92..1e16bc097 100644 --- a/doc/bugs/post-commit_hangs.mdwn +++ b/doc/bugs/post-commit_hangs.mdwn @@ -20,6 +20,10 @@ I installed ikiwiki v3.14159 in /usr/local from tarball (/usr contains an older >>> Or, you can use the `--post-commit` option, as documented >>> in [[rcs/mecurial]] --[[Joey]] +>>>> I don't run ikiwiki --setup in the commit hook; I run ikiwiki --post-commit (as mentioned above). +>>>> I'm trying to run ikiwiki --setup from the command line after modifying the setup file. +>>>> ikiwiki --setup is calling hg update, which is calling ikiwiki --post-commit. Am I not supposed to do that? --Ali + > Also, how have you arranged to keep it from seeing the installation in /usr? Perl could well be loading > modules from the old installation, and if it's one with a different locking strategy that would explain your problem. --[[Joey]] -- cgit v1.2.3 From e46ea2a687b97e96c54e21169f41f14f9b21728c Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 4 Aug 2009 16:38:22 -0400 Subject: response --- doc/bugs/post-commit_hangs.mdwn | 3 +++ 1 file changed, 3 insertions(+) (limited to 'doc/bugs/post-commit_hangs.mdwn') diff --git a/doc/bugs/post-commit_hangs.mdwn b/doc/bugs/post-commit_hangs.mdwn index 1e16bc097..ee7f881d5 100644 --- a/doc/bugs/post-commit_hangs.mdwn +++ b/doc/bugs/post-commit_hangs.mdwn @@ -24,6 +24,9 @@ I installed ikiwiki v3.14159 in /usr/local from tarball (/usr contains an older >>>> I'm trying to run ikiwiki --setup from the command line after modifying the setup file. >>>> ikiwiki --setup is calling hg update, which is calling ikiwiki --post-commit. Am I not supposed to do that? --Ali +>>>>> No, I don't think that hg update should call ikiwiki anything. The +>>>>> [[hgrc_example|rcs/mercurial]] doesn't seem to configure it to do that? --[[Joey]] + > Also, how have you arranged to keep it from seeing the installation in /usr? Perl could well be loading > modules from the old installation, and if it's one with a different locking strategy that would explain your problem. --[[Joey]] -- cgit v1.2.3 From 2b98b1a0c1075a28ae43259b6591df25a4b2029c Mon Sep 17 00:00:00 2001 From: j-ali Date: Tue, 4 Aug 2009 16:45:30 -0400 Subject: --- doc/bugs/post-commit_hangs.mdwn | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'doc/bugs/post-commit_hangs.mdwn') diff --git a/doc/bugs/post-commit_hangs.mdwn b/doc/bugs/post-commit_hangs.mdwn index ee7f881d5..a013f7919 100644 --- a/doc/bugs/post-commit_hangs.mdwn +++ b/doc/bugs/post-commit_hangs.mdwn @@ -27,6 +27,18 @@ I installed ikiwiki v3.14159 in /usr/local from tarball (/usr contains an older >>>>> No, I don't think that hg update should call ikiwiki anything. The >>>>> [[hgrc_example|rcs/mercurial]] doesn't seem to configure it to do that? --[[Joey]] +>>>>>> Ok, I'm not sure I understand what's going on, but my problem is solved. +>>>>>> +>>>>>> My hgrc used to say: +>>>>>> +>>>>>> [hooks] +>>>>>> +>>>>>> incoming.update = hg up +>>>>>> +>>>>>> update.ikiwiki = ikiwiki --setup /home/ikiwiki/ikiwiki.setup --post-commit +>>>>>> +>>>>>> I've now changed it to match the example page and it works. Thanks --Ali. + > Also, how have you arranged to keep it from seeing the installation in /usr? Perl could well be loading > modules from the old installation, and if it's one with a different locking strategy that would explain your problem. --[[Joey]] -- cgit v1.2.3 From 4a2a37e02e2a07de0d3c22265392776f4fdb7676 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 4 Aug 2009 16:52:12 -0400 Subject: close --- doc/bugs/post-commit_hangs.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/bugs/post-commit_hangs.mdwn') diff --git a/doc/bugs/post-commit_hangs.mdwn b/doc/bugs/post-commit_hangs.mdwn index a013f7919..32820d886 100644 --- a/doc/bugs/post-commit_hangs.mdwn +++ b/doc/bugs/post-commit_hangs.mdwn @@ -39,6 +39,8 @@ I installed ikiwiki v3.14159 in /usr/local from tarball (/usr contains an older >>>>>> >>>>>> I've now changed it to match the example page and it works. Thanks --Ali. +>>>>>>> [[done]] + > Also, how have you arranged to keep it from seeing the installation in /usr? Perl could well be loading > modules from the old installation, and if it's one with a different locking strategy that would explain your problem. --[[Joey]] -- cgit v1.2.3