From 0d76893483f961755dc181d4a2fd2ee3af1373ea Mon Sep 17 00:00:00 2001 From: "http://smcv.pseudorandom.co.uk/" Date: Mon, 22 Jun 2009 06:57:00 -0400 Subject: bug report + patches --- .../openid_no_longer_pretty-prints_OpenIDs.mdwn | 23 ++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn (limited to 'doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn') diff --git a/doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn b/doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn new file mode 100644 index 000000000..a2bb5893a --- /dev/null +++ b/doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn @@ -0,0 +1,23 @@ +The git commit (in my `openid` branch) says it all: + + Update IkiWiki::openiduser to work with Net::OpenID 2.x + + openiduser previously used a constructor that no longer works in 2.x. + However, all we actually want is the (undocumented) DisplayOfURL function + that is invoked by the display method, so try to use that. + +This bug affects ikiwiki.info (my commits show up in [[RecentChanges]] as http://smcv.pseudorandom.co.uk/ rather than smcv [pseudorandom.co.uk]). + +Relatedly, the other commit on the same branch would be nice to have: + + Allow the openid plugin to be loaded but disabled, for its side-effect of defining IkiWiki::openiduser + + On various sites I have two IkiWiki instances running from the same + repository: one accessible via http and only accepting openid logins, + and one accessible via authenticated https and only accepting httpauth. + Ideally, the https version should still pretty-print OpenIDs seen in + git history. + +--[[smcv]] + +[[!tag patch]] -- cgit v1.2.3 From df6430afae4632c000cee2b6bfbcd5c8c759dd83 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 7 Jul 2009 13:40:17 -0400 Subject: response --- doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn') diff --git a/doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn b/doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn index a2bb5893a..1e2030b23 100644 --- a/doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn +++ b/doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn @@ -8,6 +8,8 @@ The git commit (in my `openid` branch) says it all: This bug affects ikiwiki.info (my commits show up in [[RecentChanges]] as http://smcv.pseudorandom.co.uk/ rather than smcv [pseudorandom.co.uk]). +> Cherry picked, thanks. --[[Joey]] + Relatedly, the other commit on the same branch would be nice to have: Allow the openid plugin to be loaded but disabled, for its side-effect of defining IkiWiki::openiduser @@ -20,4 +22,8 @@ Relatedly, the other commit on the same branch would be nice to have: --[[smcv]] +> I wonder if an option is the best approach. Maybe it would be better to +> simply move `openiduser` into `userlink`, and thus always support openid +> usernames whether the plugin is enabled or not. --[[Joey]] + [[!tag patch]] -- cgit v1.2.3 From 1c614914cc7b5fe187298dad88bafa0bdf8f106c Mon Sep 17 00:00:00 2001 From: "smcv@" Date: Fri, 10 Jul 2009 18:56:47 +0100 Subject: Close bug (joeyh merged my patch), split out feature request, provide alternative patch --- .../openid_no_longer_pretty-prints_OpenIDs.mdwn | 22 +++++--------------- .../pretty-print_OpenIDs_even_if_not_enabled.mdwn | 24 ++++++++++++++++++++++ 2 files changed, 29 insertions(+), 17 deletions(-) create mode 100644 doc/todo/pretty-print_OpenIDs_even_if_not_enabled.mdwn (limited to 'doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn') diff --git a/doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn b/doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn index 1e2030b23..85a206bc0 100644 --- a/doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn +++ b/doc/bugs/openid_no_longer_pretty-prints_OpenIDs.mdwn @@ -8,22 +8,10 @@ The git commit (in my `openid` branch) says it all: This bug affects ikiwiki.info (my commits show up in [[RecentChanges]] as http://smcv.pseudorandom.co.uk/ rather than smcv [pseudorandom.co.uk]). -> Cherry picked, thanks. --[[Joey]] +> Cherry picked, thanks. --[[Joey]] -Relatedly, the other commit on the same branch would be nice to have: +Relatedly, the other commit on the same branch would be nice to have +(edited to add: I've now moved it, and its discussion, to +[[todo/pretty-print_OpenIDs_even_if_not_enabled]]). --[[smcv]] - Allow the openid plugin to be loaded but disabled, for its side-effect of defining IkiWiki::openiduser - - On various sites I have two IkiWiki instances running from the same - repository: one accessible via http and only accepting openid logins, - and one accessible via authenticated https and only accepting httpauth. - Ideally, the https version should still pretty-print OpenIDs seen in - git history. - ---[[smcv]] - -> I wonder if an option is the best approach. Maybe it would be better to -> simply move `openiduser` into `userlink`, and thus always support openid -> usernames whether the plugin is enabled or not. --[[Joey]] - -[[!tag patch]] +[[!tag done]] diff --git a/doc/todo/pretty-print_OpenIDs_even_if_not_enabled.mdwn b/doc/todo/pretty-print_OpenIDs_even_if_not_enabled.mdwn new file mode 100644 index 000000000..373c120a6 --- /dev/null +++ b/doc/todo/pretty-print_OpenIDs_even_if_not_enabled.mdwn @@ -0,0 +1,24 @@ +A feature I originally requested on +[[a_related_bug|bugs/openid_no_longer_pretty-prints_OpenIDs]]: + + Allow the openid plugin to be loaded but disabled, for its side-effect of defining IkiWiki::openiduser + + On various sites I have two IkiWiki instances running from the same + repository: one accessible via http and only accepting openid logins, + and one accessible via authenticated https and only accepting httpauth. + Ideally, the https version should still pretty-print OpenIDs seen in + git history. + +--[[smcv]] + +> I wonder if an option is the best approach. Maybe it would be better to +> simply move `openiduser` into `userlink`, and thus always support openid +> usernames whether the plugin is enabled or not. --[[Joey]] + +>> OK, implemented that as 'smcv/always-openid'; if you don't think that's +>> bloating the IkiWiki core too much, please consider merging. The poll on +>> [[news/openid]] indicates fairly strong support for *only* accepting OpenID +>> logins, so I think recognising OpenIDs can reasonably be considered core +>> functionality! --[[smcv]] + +[[!tag patch]] -- cgit v1.2.3