From e1eee27fc59dd6126e80ef21e4cc44191119902c Mon Sep 17 00:00:00 2001 From: "http://hendry.iki.fi/" Date: Sun, 28 Mar 2010 20:01:41 +0000 Subject: --- doc/bugs/Comments_dissapeared.mdwn | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 doc/bugs/Comments_dissapeared.mdwn (limited to 'doc/bugs/Comments_dissapeared.mdwn') diff --git a/doc/bugs/Comments_dissapeared.mdwn b/doc/bugs/Comments_dissapeared.mdwn new file mode 100644 index 000000000..f71a442b8 --- /dev/null +++ b/doc/bugs/Comments_dissapeared.mdwn @@ -0,0 +1,9 @@ +Although I have comments enabled and I have been using them successfully for ages now, I've come to notice that they have stopped working in the last week or two. + +I am running version 3.20100312 with the following configuration: + + + +In my (HTML5 modified page.tmpl) it doesn't seem to enter the "TMPL_IF COMMENTS" block anymore. I tried the stock page.tmpl and they didn't seem to work either, so the variable name hasn't changed has it? + +Any other ideas? With thanks, -- cgit v1.2.3 From a1f50f6a31d4e9f7acd6f8d445e5fb39edba5138 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 28 Mar 2010 17:37:42 -0400 Subject: response --- doc/bugs/Comments_dissapeared.mdwn | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'doc/bugs/Comments_dissapeared.mdwn') diff --git a/doc/bugs/Comments_dissapeared.mdwn b/doc/bugs/Comments_dissapeared.mdwn index f71a442b8..b737d9bef 100644 --- a/doc/bugs/Comments_dissapeared.mdwn +++ b/doc/bugs/Comments_dissapeared.mdwn @@ -7,3 +7,9 @@ I am running version 3.20100312 with the following configuration: In my (HTML5 modified page.tmpl) it doesn't seem to enter the "TMPL_IF COMMENTS" block anymore. I tried the stock page.tmpl and they didn't seem to work either, so the variable name hasn't changed has it? Any other ideas? With thanks, + + comments_pagespec => 'archives/* and !*/Discussion', + +> Your setup file only allows comments to pages under archives. That +> seems unlikely to be right, so I guess it is causing your problem. +> --[[Joey]] -- cgit v1.2.3 From ae4e9b25b714b02ed7003a21da781fccf9475f38 Mon Sep 17 00:00:00 2001 From: "http://hendry.iki.fi/" Date: Mon, 29 Mar 2010 08:15:43 +0000 Subject: --- doc/bugs/Comments_dissapeared.mdwn | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'doc/bugs/Comments_dissapeared.mdwn') diff --git a/doc/bugs/Comments_dissapeared.mdwn b/doc/bugs/Comments_dissapeared.mdwn index b737d9bef..ad1638236 100644 --- a/doc/bugs/Comments_dissapeared.mdwn +++ b/doc/bugs/Comments_dissapeared.mdwn @@ -13,3 +13,8 @@ Any other ideas? With thanks, > Your setup file only allows comments to pages under archives. That > seems unlikely to be right, so I guess it is causing your problem. > --[[Joey]] + +That's the only place where I want comments. +Has the pagespec changed? Is it `archives/*/*` or something like that? + +It worked just fine with this configuration. I swear I have not modified it. :) -- [[Kai Hendry]] -- cgit v1.2.3 From b2890b4e8ff0dc0e0fbaed1ffd9848c48dedf611 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 29 Mar 2010 15:25:34 -0400 Subject: response --- doc/bugs/Comments_dissapeared.mdwn | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'doc/bugs/Comments_dissapeared.mdwn') diff --git a/doc/bugs/Comments_dissapeared.mdwn b/doc/bugs/Comments_dissapeared.mdwn index ad1638236..ac297028c 100644 --- a/doc/bugs/Comments_dissapeared.mdwn +++ b/doc/bugs/Comments_dissapeared.mdwn @@ -18,3 +18,13 @@ That's the only place where I want comments. Has the pagespec changed? Is it `archives/*/*` or something like that? It worked just fine with this configuration. I swear I have not modified it. :) -- [[Kai Hendry]] + +> No changes that I can think of. 'archives/*' will match *all* pages under +> archives. Anyway, I can see in your site's rss feed that comments are +> enabled for posts, since they have comments tags there. And +> in fact I see comments on eg +> . +> +> So I suspect you have simply not rebuilt your wiki after making some +> change that fixed the comments, and so only newer pages are getting them. +> --[[Joey]] -- cgit v1.2.3 From 3a02cfca99922e8e15b55962d534629b777e463f Mon Sep 17 00:00:00 2001 From: "http://hendry.iki.fi/" Date: Sun, 4 Apr 2010 13:00:52 +0000 Subject: --- doc/bugs/Comments_dissapeared.mdwn | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'doc/bugs/Comments_dissapeared.mdwn') diff --git a/doc/bugs/Comments_dissapeared.mdwn b/doc/bugs/Comments_dissapeared.mdwn index ac297028c..7ff1a012f 100644 --- a/doc/bugs/Comments_dissapeared.mdwn +++ b/doc/bugs/Comments_dissapeared.mdwn @@ -28,3 +28,8 @@ It worked just fine with this configuration. I swear I have not modified it. :) > So I suspect you have simply not rebuilt your wiki after making some > change that fixed the comments, and so only newer pages are getting them. > --[[Joey]] + +I have tried rebuilding on my squeeze system and still comments don't appear. Any clues how to debug this? + + +I was worried is was due to a time skew problem I was experiencing on my VPS in the last month, though the time is right now and still comments do not appear on blog posts like -- cgit v1.2.3 From e72973afdb3b08b1755295e348e223a7c51cf702 Mon Sep 17 00:00:00 2001 From: "http://hendry.iki.fi/" Date: Wed, 21 Apr 2010 19:07:32 +0000 Subject: debugging --- doc/bugs/Comments_dissapeared.mdwn | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'doc/bugs/Comments_dissapeared.mdwn') diff --git a/doc/bugs/Comments_dissapeared.mdwn b/doc/bugs/Comments_dissapeared.mdwn index 7ff1a012f..c7403f0f1 100644 --- a/doc/bugs/Comments_dissapeared.mdwn +++ b/doc/bugs/Comments_dissapeared.mdwn @@ -33,3 +33,15 @@ I have tried rebuilding on my squeeze system and still comments don't appear. An I was worried is was due to a time skew problem I was experiencing on my VPS in the last month, though the time is right now and still comments do not appear on blog posts like + +# Getting closer + + hendry@webconverger templates$ for i in *.tmpl; do ./test-template.perl $i || echo $i has an error; done + HTML::Template->new() : At least one or not terminated at end of file! at /usr/share/perl5/HTML/Template.pm line 2351. + page.tmpl has an error + hendry@webconverger templates$ cat test-template.perl + #!/usr/bin/perl + use HTML::Template; + my $htc = HTML::Template->new(filename => "$ARGV[0]"); + +I think the problem was before that it was `` and now it is `` ? -- cgit v1.2.3 From 9ed523d762afd74c3004a07fc8ee12daa9354813 Mon Sep 17 00:00:00 2001 From: "http://hendry.iki.fi/" Date: Wed, 21 Apr 2010 19:21:38 +0000 Subject: --- doc/bugs/Comments_dissapeared.mdwn | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) (limited to 'doc/bugs/Comments_dissapeared.mdwn') diff --git a/doc/bugs/Comments_dissapeared.mdwn b/doc/bugs/Comments_dissapeared.mdwn index c7403f0f1..830c3519f 100644 --- a/doc/bugs/Comments_dissapeared.mdwn +++ b/doc/bugs/Comments_dissapeared.mdwn @@ -34,14 +34,28 @@ I have tried rebuilding on my squeeze system and still comments don't appear. An I was worried is was due to a time skew problem I was experiencing on my VPS in the last month, though the time is right now and still comments do not appear on blog posts like -# Getting closer +# Debugging templates - hendry@webconverger templates$ for i in *.tmpl; do ./test-template.perl $i || echo $i has an error; done - HTML::Template->new() : At least one or not terminated at end of file! at /usr/share/perl5/HTML/Template.pm line 2351. - page.tmpl has an error - hendry@webconverger templates$ cat test-template.perl +`sudo apt-get install libhtml-template-compiled-perl` + + hendry@webconverger templates$ cat test-template.perl #!/usr/bin/perl - use HTML::Template; - my $htc = HTML::Template->new(filename => "$ARGV[0]"); + use HTML::Template::Compiled; + local $HTML::Template::Compiled::DEBUG = 1; + my $htc = HTML::Template::Compiled->new( + filename => "$ARGV[0]", + ); + eval { + print $htc->output; + }; + if ($@) { + # reports as text + my $msg = $htc->debug_code; + # reports as a html table + my $msg_html = $htc->debug_code('html'); + } + hendry@webconverger templates$ ./test-template.perl page.tmpl + Missing closing tag for 'IF' atend of page.tmpl line 159 + I think the problem was before that it was `` and now it is `` ? -- cgit v1.2.3 From 86e73e42e835821984fdf6dc5671dae06cec5f90 Mon Sep 17 00:00:00 2001 From: "http://hendry.iki.fi/" Date: Wed, 21 Apr 2010 19:48:31 +0000 Subject: --- doc/bugs/Comments_dissapeared.mdwn | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'doc/bugs/Comments_dissapeared.mdwn') diff --git a/doc/bugs/Comments_dissapeared.mdwn b/doc/bugs/Comments_dissapeared.mdwn index 830c3519f..787f18c98 100644 --- a/doc/bugs/Comments_dissapeared.mdwn +++ b/doc/bugs/Comments_dissapeared.mdwn @@ -59,3 +59,11 @@ I was worried is was due to a time skew problem I was experiencing on my VPS in I think the problem was before that it was `` and now it is `` ? + + + +# Solved + +A merge with the templates in master with my [html5](http://git.webconverger.org/?p=ikiwiki;a=shortlog;h=refs/heads/html5) branch looks like it has solved the problem. Also see [[bugs/html5_support]]. + +[[bugs/done]] -- cgit v1.2.3