From 779c5214f330269fa95a5fed5b16fe8d65730102 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 19 Sep 2008 13:09:50 -0400 Subject: progress: Display an error if the progress cannot be parsed, and allow the percent parameter to only optionally end with "%". --- IkiWiki/Plugin/progress.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'IkiWiki') diff --git a/IkiWiki/Plugin/progress.pm b/IkiWiki/Plugin/progress.pm index e459637b8..6cb21a916 100644 --- a/IkiWiki/Plugin/progress.pm +++ b/IkiWiki/Plugin/progress.pm @@ -5,7 +5,7 @@ use warnings; use strict; use IkiWiki 2.00; -my $percentage_pattern = qr/[0-9]+\%/; # pattern to validate percentages +my $percentage_pattern = qr/[0-9]+\%?/; # pattern to validate percentages sub import { #{{{ hook(type => "getsetup", id => "progress", call => \&getsetup); @@ -29,6 +29,12 @@ sub preprocess (@) { #{{{ if (defined $params{percent}) { $fill = $params{percent}; ($fill) = $fill =~ m/($percentage_pattern)/; # fill is untainted now + if (! defined $fill || ! length $fill || $fill > 100 || $fill < 0) { + error("illegal percent value $params{percent}"); + } + elsif ($fill !~ /%$/) { + $fill.="%"; + } } elsif (defined $params{totalpages} and defined $params{donepages}) { add_depends($params{page}, $params{totalpages}); -- cgit v1.2.3