From ed05e40566a8d2a39530507598d835764885cf73 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 21 Jul 2008 22:11:24 -0400 Subject: error if nothing selected --- IkiWiki/Plugin/remove.pm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/IkiWiki/Plugin/remove.pm b/IkiWiki/Plugin/remove.pm index 7cc1d615e..21028cde3 100644 --- a/IkiWiki/Plugin/remove.pm +++ b/IkiWiki/Plugin/remove.pm @@ -30,7 +30,6 @@ sub confirmation_form ($$) { #{{{ eval q{use CGI::FormBuilder}; error($@) if $@; - my @fields=qw(do page); my $f = CGI::FormBuilder->new( name => "remove", header => 0, @@ -40,7 +39,7 @@ sub confirmation_form ($$) { #{{{ params => $q, action => $config{cgiurl}, stylesheet => IkiWiki::baseurl()."style.css", - fields => \@fields, + fields => [qw{do page}], ); $f->field(name => "do", type => "hidden", value => "remove", force => 1); @@ -98,7 +97,11 @@ sub formbuilder (@) { #{{{ removal_confirm($q, $session, 0, $form->field("page")); } elsif ($form->submitted eq "Remove Attachments") { - removal_confirm($q, $session, 1, $q->param("attachment_select")); + my @pages=$q->param("attachment_select"); + if (! @pages) { + error(gettext("Please select the attachments to remove.")); + } + removal_confirm($q, $session, 1, @pages); } } } #}}} -- cgit v1.2.3