summaryrefslogtreecommitdiff
path: root/doc/bugs
AgeCommit message (Collapse)Author
2008-07-10questionJoey Hess
2008-07-10escapeJoey Hess
2008-07-10Fixes creation of pages when clicking on WikiLinks starting with "/".Joey Hess
2008-07-10web commit by intrigeri: initial bug submissionJoey Hess
2008-07-10web commit by intrigeri: added opinion + patchJoey Hess
2008-07-09web commit by http://ptecza.myopenid.com/: * Confirmation and thanksJoey Hess
2008-07-09remove patch tagJoey Hess
2008-07-09closeJoey Hess
2008-07-09closeJoey Hess
2008-07-08responseJoey Hess
2008-07-08web commit by AndrewGreenberg: bad formatting on bug report, sorry.Joey Hess
2008-07-08web commit by AndrewGreenberg: Added nasty URL edit bug in 2.52.Joey Hess
2008-07-08Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.infoJoey Hess
Conflicts: doc/bugs/attachment:_failed_to_get_filehandle.mdwn
2008-07-08attachment: Support perl 5.8's buggy version of CGI.pm.Joey Hess
This is truely horribly disgusting. CGI::tmpFileName, in current perls, is an undocumented function (which should be a clue..) that takes the original filename of an uploaded attachment, and returns the name of the tempfile that CGI has stored it in. In old perls, though, CGI::tmpFileName does not take a filename. It takes a key from the object's {'.tmpfiles'} hash. This key is something crazy like '*Fh::fh00001group' -- apparently the stringification of a filehandle object. Just to add to the fun, tmpFileName doesn't take the key, it expects a refernce to the key. Argh?! But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken in two other ways. The upload() method is supposed to return a filehandle to the temp file. It doesn't. The param() method is supposed to return a filehandle to the temp file, that stringifies to the original filename. It returns just the original filename, no filehandle. Combine all these bugs, and you end up with this disgusting commit. Since I have no way to get the filehandle, I *need* to get the tempfile name. If I had the filehandle, I could probably pass it into tmpFileName, and it might strigify to the right key name. But I don't, so the only way to determine the key is to grub through the .tmpfiles hash ourselves. And finally, one the temp file name is discovered, a filehandle can finally be obtained by (re)opening it. I recommend that this commit be reverted when perl 5.8 is a mercifully faded memory. I'm really, really, really glad I'm actually being paid for working on this right now!
2008-07-08web commit by http://ptecza.myopenid.com/: * Thanks!Joey Hess
2008-07-08web commit by HenrikBrixAndersen: This happens on FreeBSD as wellJoey Hess
2008-07-08reproducedJoey Hess
2008-07-08responseJoey Hess
2008-07-08web commit by http://ptecza.myopenid.com/: * The bug still occursJoey Hess
2008-07-08undef $fh before openingJoey Hess
2008-07-08web commit by http://ptecza.myopenid.com/: * Still no successJoey Hess
2008-07-08responseJoey Hess
2008-07-08another try at dealing with CGI.pm problemJoey Hess
open the temp file if all attempts to get a fd fail
2008-07-08web commit by http://ptecza.myopenid.com/: * Debugging againJoey Hess
2008-07-08possible fixJoey Hess
2008-07-08web commit by http://ptecza.myopenid.com/: * Next debbugingJoey Hess
2008-07-08new thing to tryJoey Hess
2008-07-08fix fixJoey Hess
2008-07-08closeJoey Hess
2008-07-08web commit by http://ptecza.myopenid.com/: * Missing Apache2 versionJoey Hess
2008-07-08web commit by http://ptecza.myopenid.com/: * ResponseJoey Hess
2008-07-08split out separate bugJoey Hess
2008-07-08responseJoey Hess
2008-07-08attachment: Fix an uninitialised value warning when editing a page that ↵Joey Hess
currently has no attachments.
2008-07-08web commit by http://ptecza.myopenid.com/: * Problem with colon in report ↵Joey Hess
page name
2008-07-08web commit by http://ptecza.myopenid.com/: * Problem with uploading attachmentsJoey Hess
2008-07-08web commit by http://ptecza.myopenid.com/: * Thanks!Joey Hess
2008-07-07web commit by http://www.openidfrance.fr/beaufilsJoey Hess
2008-07-07responseJoey Hess
2008-07-07web commit by http://ptecza.myopenid.com/: * Enabling attachment pluginJoey Hess
2008-07-07search: generate configuration files once only when rebuilding (Gabriel McManus)Joey Hess
2008-07-07web commit by http://gmcmanus.myopenid.com/: search: create configuration ↵Joey Hess
once only on rebuild
2008-07-06editpage escaping fixesJoey Hess
* The editpage form now uses the raw page name, not the page title, in its 'page' cgi parameter. Using the title was ambiguous and made it impossible to tell between some pages, like "foo/bar" and "foo__47__bar", sometimes causing the wrong page to be edited. * This change means that some edit links need to be updated. Force a rebuild on upgrade to this version. * Above change also allowed really fixing escaped slashes from the blogpost form.
2008-07-06responseJoey Hess
2008-07-06responseJoey Hess
2008-07-06rmJoey Hess
2008-07-05web commit by http://www.openidfrance.fr/beaufilsJoey Hess
2008-07-05web commit by http://www.openidfrance.fr/beaufilsJoey Hess
2008-07-05web commit by http://www.openidfrance.fr/beaufilsJoey Hess
2008-07-05web commit by http://www.openidfrance.fr/beaufilsJoey Hess
generated by cgit v1.2.3 (git 2.46.0) at 2024-12-30 04:59:00 +0000