summaryrefslogtreecommitdiff
path: root/IkiWiki
AgeCommit message (Collapse)Author
2008-12-28releasing version 2.72Joey Hess
2008-12-26inline: Run format hook firstJoey Hess
inline has a format hook that is an optimisation hack. Until this hook runs, the inlined content is not present on the page. This can prevent other format hooks, that process that content, from acting on inlined content. In bug ##509710, we discovered this happened commonly for the embed plugin, but it could in theory happen for many other plugins (color, cutpaste, etc) that use format to fill in special html after sanitization. The ordering was essentially random (hash key order). That's kinda a good thing, because hooks should be independent of other hooks and able to run in any order. But for things like inline, that just doesn't work. To fix the immediate problem, let's make hooks able to be registered as running "first". There was already the ability to make them run "last". Now, this simple first/middle/last ordering is obviously not going to work if a lot of things need to run first, or last, since then we'll be back to being unable to specify ordering inside those sets. But before worrying about that too much, and considering dependency ordering, etc, observe how few plugins use last ordering: Exactly one needs it. And, so far, exactly one needs first ordering. So for now, KISS. Another implementation note: I could have sorted the plugins with first/last/middle as the primary key, and plugin name secondary, to get a guaranteed stable order. Instead, I chose to preserve hash order. Two opposing things pulled me toward that decision: 1. Since has order is randomish, it will ensure that no accidental ordering assumptions are made. 2. Assume for a minute that ordering matters a lot more than expected. Drastically changing the order a particular configuration uses could result in a lot of subtle bugs cropping up. (I hope this assumption is false, partly due to #1, but can't rule it out.)
2008-12-26comments: Deal with users entering unqualified or partial urls.Joey Hess
People seem to be able to expect to enter www.foo.com and get away with it. The resulting my.wiki/www.foo.com link was not ideal. To fix it, use URI::Heuristic to expand such things into a real url. It even looks up hostnames in the DNS if necessary.
2008-12-25googlecalendar: Add runtime deprecation warning.Joey Hess
2008-12-23camelcase: Add camelcase_ignore setting.Joey Hess
2008-12-22recentchanges_link CGI: If the linked page is internal, use its permalinkSimon McVittie
This fixes a bug, that comments appear in recentchanges as broken links.
2008-12-21Merge commit 'smcv/openid'Joey Hess
2008-12-21comments: substitute commentsurl and atomcommentsurl for use in feedsSimon McVittie
2008-12-21openid: in &openiduser, allow subdirectory-style providers to end with '/'Simon McVittie
This improves the display of OpenIDs like 'http://id.mayfirst.org/jamie/' (taking an example from the IkiWiki commit log).
2008-12-21openid: in &openiduser, let domain-style providers have arbitrarily many ↵Simon McVittie
subdomains This leads to better display for OpenIDs like smcv.pseudorandom.co.uk and thm.id.fedoraproject.org (to take a couple of examples from the IkiWiki commit history).
2008-12-21comments: run pagetemplate hooksSimon McVittie
This fixes the bug that comments are always said to be from an anonymous user at an unknown IP address.
2008-12-21comments: linkify and preprocess preview with correct 'page' paramSimon McVittie
2008-12-21meta: Process meta date during scan pass so that the date will always affect ↵Joey Hess
sorting in inlines.
2008-12-20avoid storing transient state in pagestateJoey Hess
None of the comment state needs to be stored through the a later run of ikiwiki, so move it all from pagestate to a more transient storage. This is assuming that we'll never want to add pagespecs to search against the comment state. Pagespecs like author() are why the meta plugin does store its meta data in pagestate -- the data can be needed later to match against.
2008-12-20comments: Rename COMMENTURL to ADDCOMMENTURL to avoid confusion with ↵Simon McVittie
COMMENTAUTHORURL Also refactor page.tmpl to use if/else rather than unless/if.
2008-12-20comments: pass COMMENTOPENID to templatesSimon McVittie
2008-12-20comments: remove linkuser(), it's been integrated into preprocess() nowSimon McVittie
2008-12-20_comment directive: if the user looks like an OpenID, store thatSimon McVittie
2008-12-19avoid uninitialized valueJoey Hess
This can happen when a new field, such as the new lasttry, is added.
2008-12-19fix comment permalink to always point to comment parent pageJoey Hess
2008-12-19remove cruftJoey Hess
wtf does it do? absolutely nothing
2008-12-19rename comments_form to editcommentJoey Hess
2008-12-19rename comments_display to commentJoey Hess
2008-12-19replace discussion links on pages with comments linkJoey Hess
The thinking here is that having both a Discussion page and comments for the same page is redundant, and certianly not what you want if you enable comments for a page. At first I considered making configurable via pagespec what pages got discussion links. But that would mean testing a new pagespec for every page, and a redundant config setting to keep in sync. So intead, take a lead from my previous change to make inlined pages have a comments link, and change the discussion link at the top of regular pages to link to their comments. (Implementation is a bit optimised to avoid redundant pagespec checking.)
2008-12-18jump to comment after postingJoey Hess
Jumping to the just posted comment was the imputus, but I killed a number of birds here. Added a INLINEPAGE template variable, which can be used to add anchors to any inline template. To keep that sufficiently general, it is the full page name, so the comment anchors and links changed form. Got rid of the FIXMEd hardcoded html anchor div. More importantly, the anchor is now to the very top of the comment, not the text below. So you can see the title, and how it attributes you. Avoid changing the permalink of pages that are not really comments, but happen to contain the _comment directive. I think that behavior was a bug, though not a likely one to occur since _comment should only really be used on comment pages.
2008-12-17aggregate: If a feed fails to be downloaded, try again immediatly next time ↵Joey Hess
aggregation is run, even if the usual time has not passed. Closes: #508622 (Michael Gold)
2008-12-17jump to comments anchor after postJoey Hess
Not ideal, it would be nicer to jump to the actual comment posted, but no anchor is available.
2008-12-17typoJoey Hess
2008-12-17add Comments link when displaying a page inlineJoey Hess
This link will supplant the usual Discussion link for pages that have comments enabled.
2008-12-17fix test when comments_closed_pagespec is emptyJoey Hess
2008-12-17change around comments pagespecsJoey Hess
I think it is clearer to have one pagespec that controls all pages with comments, and a separate pagespec that can be used to close new comments on a subset of those pages.
2008-12-17fix default values for config settingsJoey Hess
defaults cannot be set in getsetup, do it in checkconfig to avoid uninitialized value warnings.
2008-12-17Coding style change: Remove explcit vim folding markers.Joey Hess
2008-12-17checksessionexpiry: reworkJoey Hess
This function as factored out was a bit confusing, I think this makes more sense.
2008-12-17Merge branch 'master' into commentsJoey Hess
2008-12-17monotone: When getting the log, tell monotone how many entries we want, ↵Joey Hess
rather than closing the pipe, which it dislikes. (thm)
2008-12-17rename: Fix double-escaping of page name in edit box.Joey Hess
titlepage normally escapes, but so does formbuilder.
2008-12-12elide unnecessary variablesJoey Hess
2008-12-12remove fixmeJoey Hess
sessioncgi hooks are always called with the wiki locked
2008-12-12fix redefinition of $authorJoey Hess
2008-12-12move related code togetherJoey Hess
2008-12-12whitespaceJoey Hess
2008-12-12don't explicitly use inlineJoey Hess
loadplugin("inline") should take care of that
2008-12-12avoid unnecessary variableJoey Hess
2008-12-12get rid of the [postcomment] hackJoey Hess
I think that using a flag variable is sorta cleaner. (This is untested.)
2008-12-12move getsetup to usual placeJoey Hess
2008-12-12htmlbalance: don't compact whitespace, and set misc other optionsSimon McVittie
Not compacting whitespace is the most important one: now that we run sanitize hooks on individual posted comments in the comments plugin, whitespace that is significant to Markdown (but not HTML) is lost. (cherry picked from commit cb5aaa3cee8b35d6fc6e88a7449a9477a6587c7a)
2008-12-12Merge branch 'master' into commentsJoey Hess
2008-12-12meta: Pass info to htmlscrubber so htmlscrubber_skip can take effect.Joey Hess
2008-12-12comments: Store dates in GMT and in ISO-8601Simon McVittie
The [[!_comment]] directive is a serialization format, not something for presentation to users, so we should use the least ambiguous possible representation.