| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
(otherwise leave it alone, so we can assign non-UUID <id>s to Atom items to avoid planet-flooding)
|
|
a page, then pass it into the rssitem/atomitem templates
|
|
|
|
|
|
This ensures that the same link is reached as is used on pages,
so browsers will know that the link on pages has been visited, and color it
appropriately.
|
|
|
|
|
|
|
|
This is truely horribly disgusting. CGI::tmpFileName, in current perls, is
an undocumented function (which should be a clue..) that takes the original
filename of an uploaded attachment, and returns the name of the tempfile
that CGI has stored it in.
In old perls, though, CGI::tmpFileName does not take a filename. It takes
a key from the object's {'.tmpfiles'} hash. This key is something
crazy like '*Fh::fh00001group' -- apparently the stringification of a
filehandle object.
Just to add to the fun, tmpFileName doesn't take the key, it expects a
refernce to the key. Argh?!
But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken
in two other ways. The upload() method is supposed to return a filehandle
to the temp file. It doesn't. The param() method is supposed to return
a filehandle to the temp file, that stringifies to the original filename.
It returns just the original filename, no filehandle.
Combine all these bugs, and you end up with this disgusting commit. Since
I have no way to get the filehandle, I *need* to get the tempfile name.
If I had the filehandle, I could probably pass it into tmpFileName, and
it might strigify to the right key name. But I don't, so the only way to
determine the key is to grub through the .tmpfiles hash ourselves.
And finally, one the temp file name is discovered, a filehandle can finally
be obtained by (re)opening it.
I recommend that this commit be reverted when perl 5.8 is a mercifully
faded memory.
I'm really, really, really glad I'm actually being paid for working on
this right now!
|
|
This is the default in unstable's formbuilder, but not in stable's,
and CGI multipart is needed for fule uploads.
|
|
|
|
|
|
open the temp file if all attempts to get a fd fail
|
|
|
|
currently has no attachments.
|
|
|
|
|
|
|
|
|
|
|
|
* The editpage form now uses the raw page name, not the page title, in its
'page' cgi parameter. Using the title was ambiguous and made it
impossible to tell between some pages, like "foo/bar" and "foo__47__bar",
sometimes causing the wrong page to be edited.
* This change means that some edit links need to be updated.
Force a rebuild on upgrade to this version.
* Above change also allowed really fixing escaped slashes from the blogpost
form.
|
|
|
|
|
|
|
|
|
|
closed toggles will not be displayed as the page is loading.
|
|
|
|
Also fix to work in preview mode.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
A user might specify an attachment, but not click the upload button,
and just save the whole page instead.
|
|
|
|
|
|
|
|
|
|
Make it a config setting, this way subtle load order issues don't come into
play. (As much?)
|
|
|
|
Put the attachment in a subdir of the page it's attached to,
unless that page is an "index" page.
|
|
canedit should fail first as it's a less expensive and harder to pass test
|
|
Needed to prevent uploads of locked pages as attachments.
|
|
|
|
|
