| Age | Commit message (Collapse) | Author |
|---|
|
None of the comment state needs to be stored through the a later run of
ikiwiki, so move it all from pagestate to a more transient storage.
This is assuming that we'll never want to add pagespecs to search against
the comment state. Pagespecs like author() are why the meta plugin does
store its meta data in pagestate -- the data can be needed later to match
against.
|
|
COMMENTAUTHORURL
Also refactor page.tmpl to use if/else rather than unless/if.
|
|
|
|
|
|
|
|
This can happen when a new field,
such as the new lasttry, is added.
|
|
|
|
wtf does it do? absolutely nothing
|
|
|
|
|
|
The thinking here is that having both a Discussion page and comments for
the same page is redundant, and certianly not what you want if you enable
comments for a page. At first I considered making configurable via pagespec
what pages got discussion links. But that would mean testing a new pagespec
for every page, and a redundant config setting to keep in sync. So intead,
take a lead from my previous change to make inlined pages have a comments
link, and change the discussion link at the top of regular pages to link to
their comments.
(Implementation is a bit optimised to avoid redundant pagespec checking.)
|
|
Jumping to the just posted comment was the imputus, but I killed a number
of birds here.
Added a INLINEPAGE template variable, which can be used to add anchors to
any inline template.
To keep that sufficiently general, it is the full page name, so the
comment anchors and links changed form.
Got rid of the FIXMEd hardcoded html anchor div.
More importantly, the anchor is now to the very top of the comment, not the
text below. So you can see the title, and how it attributes you.
Avoid changing the permalink of pages that are not really comments, but
happen to contain the _comment directive. I think that behavior was a bug,
though not a likely one to occur since _comment should only really be used
on comment pages.
|
|
aggregation is run, even if the usual time has not passed. Closes: #508622 (Michael Gold)
|
|
Not ideal, it would be nicer to jump to the actual comment posted, but no
anchor is available.
|
|
|
|
This link will supplant the usual Discussion link for pages
that have comments enabled.
|
|
|
|
I think it is clearer to have one pagespec that controls all pages with
comments, and a separate pagespec that can be used to close new comments on
a subset of those pages.
|
|
defaults cannot be set in getsetup, do it in checkconfig to avoid
uninitialized value warnings.
|
|
|
|
This function as factored out was a bit confusing, I think this makes more
sense.
|
|
|
|
rather than closing the pipe, which it dislikes. (thm)
|
|
titlepage normally escapes, but so does formbuilder.
|
|
|
|
sessioncgi hooks are always called with the wiki locked
|
|
|
|
|
|
|
|
loadplugin("inline") should take care of that
|
|
|
|
I think that using a flag variable is sorta cleaner.
(This is untested.)
|
|
|
|
Not compacting whitespace is the most important one: now that we run
sanitize hooks on individual posted comments in the comments plugin,
whitespace that is significant to Markdown (but not HTML) is lost.
(cherry picked from commit cb5aaa3cee8b35d6fc6e88a7449a9477a6587c7a)
|
|
|
|
|
|
The [[!_comment]] directive is a serialization format, not something for
presentation to users, so we should use the least ambiguous possible
representation.
|
|
|
|
|
|
|
|
If an admin wants the IP in the comment display template they can still
get it (the default template shows it).
|
|
|
|
|
|
Also provide a way for the comment template to pick up the verified
username/IP.
|
|
|
|
This has the side-effect that Ikiwiki's default style.css gives the text
box 100% width.
|
|
|
|
This delays all comment formatting until the last possible time, allows
us to set metadata without worrying that commenters may be able to evade
it, and means that changes to how a comment is saved can be handled
gracefully. It also gives us somewhere to put the commenter's username
or IP address for later reference.
|
|
|
|
correctly
|
