| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2008-12-19 | replace discussion links on pages with comments link | Joey Hess | |
| The thinking here is that having both a Discussion page and comments for the same page is redundant, and certianly not what you want if you enable comments for a page. At first I considered making configurable via pagespec what pages got discussion links. But that would mean testing a new pagespec for every page, and a redundant config setting to keep in sync. So intead, take a lead from my previous change to make inlined pages have a comments link, and change the discussion link at the top of regular pages to link to their comments. (Implementation is a bit optimised to avoid redundant pagespec checking.) | |||
| 2008-12-18 | jump to comment after posting | Joey Hess | |
| Jumping to the just posted comment was the imputus, but I killed a number of birds here. Added a INLINEPAGE template variable, which can be used to add anchors to any inline template. To keep that sufficiently general, it is the full page name, so the comment anchors and links changed form. Got rid of the FIXMEd hardcoded html anchor div. More importantly, the anchor is now to the very top of the comment, not the text below. So you can see the title, and how it attributes you. Avoid changing the permalink of pages that are not really comments, but happen to contain the _comment directive. I think that behavior was a bug, though not a likely one to occur since _comment should only really be used on comment pages. | |||
| 2008-12-17 | jump to comments anchor after post | Joey Hess | |
| Not ideal, it would be nicer to jump to the actual comment posted, but no anchor is available. | |||
| 2008-12-17 | typo | Joey Hess | |
| 2008-12-17 | add Comments link when displaying a page inline | Joey Hess | |
| This link will supplant the usual Discussion link for pages that have comments enabled. | |||
| 2008-12-17 | fix test when comments_closed_pagespec is empty | Joey Hess | |
| 2008-12-17 | change around comments pagespecs | Joey Hess | |
| I think it is clearer to have one pagespec that controls all pages with comments, and a separate pagespec that can be used to close new comments on a subset of those pages. | |||
| 2008-12-17 | fix default values for config settings | Joey Hess | |
| defaults cannot be set in getsetup, do it in checkconfig to avoid uninitialized value warnings. | |||
| 2008-12-17 | Coding style change: Remove explcit vim folding markers. | Joey Hess | |
| 2008-12-17 | checksessionexpiry: rework | Joey Hess | |
| This function as factored out was a bit confusing, I think this makes more sense. | |||
| 2008-12-12 | elide unnecessary variables | Joey Hess | |
| 2008-12-12 | remove fixme | Joey Hess | |
| sessioncgi hooks are always called with the wiki locked | |||
| 2008-12-12 | fix redefinition of $author | Joey Hess | |
| 2008-12-12 | move related code together | Joey Hess | |
| 2008-12-12 | whitespace | Joey Hess | |
| 2008-12-12 | don't explicitly use inline | Joey Hess | |
| loadplugin("inline") should take care of that | |||
| 2008-12-12 | avoid unnecessary variable | Joey Hess | |
| 2008-12-12 | get rid of the [postcomment] hack | Joey Hess | |
| I think that using a flag variable is sorta cleaner. (This is untested.) | |||
| 2008-12-12 | move getsetup to usual place | Joey Hess | |
| 2008-12-12 | comments: Store dates in GMT and in ISO-8601 | Simon McVittie | |
| The [[!_comment]] directive is a serialization format, not something for presentation to users, so we should use the least ambiguous possible representation. | |||
| 2008-12-11 | comments: Change internal-use-only directive from [[!comment]] to [[!_comment]] | Simon McVittie | |
| 2008-12-11 | comments: Use new feedfile, emptyfeeds options to inline | Simon McVittie | |
| 2008-12-11 | comments: don't interpolate IP into anonymous user's "name" | Simon McVittie | |
| If an admin wants the IP in the comment display template they can still get it (the default template shows it). | |||
| 2008-12-11 | comments: fix invocation of possibly_foolish_untaint | Simon McVittie | |
| 2008-12-11 | comments: avoid warning if there's no subject | Simon McVittie | |
| 2008-12-11 | comments: Optionally allow anonymous commenters to set their name/URL. | Simon McVittie | |
| Also provide a way for the comment template to pick up the verified username/IP. | |||
| 2008-12-11 | comments: Remove some dead code | Simon McVittie | |
| 2008-12-11 | comments: rename main field to "editcontent" consistent with editpage | Simon McVittie | |
| This has the side-effect that Ikiwiki's default style.css gives the text box 100% width. | |||
| 2008-12-11 | comments: instead of hard-coding mdwn, allow any supported page format | Simon McVittie | |
| 2008-12-11 | comments: Save comments as a file with one big [[!comment]] directive. | Simon McVittie | |
| This delays all comment formatting until the last possible time, allows us to set metadata without worrying that commenters may be able to evade it, and means that changes to how a comment is saved can be handled gracefully. It also gives us somewhere to put the commenter's username or IP address for later reference. | |||
| 2008-12-11 | Remove dead code for preprocessing [[!comments]] | Simon McVittie | |
| 2008-12-11 | comments: Duplicate logic and CGI hook from recentchanges to link user pages ↵ | Simon McVittie | |
| correctly | |||
| 2008-12-11 | Qualify name of formattime() correctly | Simon McVittie | |
| 2008-12-11 | Delay checking for session expiry til we actually post a comment | Simon McVittie | |
| 2008-12-11 | comments: record the time at which each comment was posted | Simon McVittie | |
| 2008-12-11 | comments: Use a checkconfig hook to get the default value of comments_pagename | Simon McVittie | |
| 2008-12-11 | comments: render comments/commenturl in page.tmpl | Simon McVittie | |
| 2008-12-11 | comments: use global config to decide whether commenting is allowed, and for ↵ | Simon McVittie | |
| name of page Also: * decide comment page name sooner * set permalink on it | |||
| 2008-12-11 | comments: use global configuration for allow_directives, commit, and pagename | Simon McVittie | |
| 2008-12-11 | comments: Add some global configuration | Simon McVittie | |
| 2008-12-11 | comments: make preprocess a no-op | Simon McVittie | |
| 2008-12-11 | comments: document what linkuser does | Simon McVittie | |
| 2008-12-11 | comments: add a stub pagetemplate hook to show the comments | Simon McVittie | |
| 2008-12-11 | comments: Use HTML entities to escape directives | Simon McVittie | |
| 2008-12-11 | Embed comments into comments_embed.tmpl rather than concatenating in perl | Simon McVittie | |
| 2008-12-11 | comments: use CGI module's checksessionexpiry | Simon McVittie | |
| 2008-12-11 | comments: remove allowhtml option, just switch it on all the time | Simon McVittie | |
| Now that posts are individually sanitized, that should be safe. | |||
| 2008-12-11 | comments: load inline and mdwn lazily | Simon McVittie | |
| 2008-12-11 | comments: don't rely on mdwn getting loaded first | Simon McVittie | |
| 2008-12-11 | comments: sanitize the body of each comment before posting it | Simon McVittie | |
| This should ensure that users can't "break out" from the enclosing <div>, making it impossible to forge comments (assuming htmlscrubber is enabled, and so is either htmlbalance or htmltidy). | |||
 |
index : ikiwiki-upstream | |
| Unnamed repository; edit this file to name it for gitweb. | Jonas Smedegaard |
| summaryrefslogtreecommitdiff |