summaryrefslogtreecommitdiff
path: root/IkiWiki/Plugin/comments.pm
AgeCommit message (Collapse)Author
2008-12-19replace discussion links on pages with comments linkJoey Hess
The thinking here is that having both a Discussion page and comments for the same page is redundant, and certianly not what you want if you enable comments for a page. At first I considered making configurable via pagespec what pages got discussion links. But that would mean testing a new pagespec for every page, and a redundant config setting to keep in sync. So intead, take a lead from my previous change to make inlined pages have a comments link, and change the discussion link at the top of regular pages to link to their comments. (Implementation is a bit optimised to avoid redundant pagespec checking.)
2008-12-18jump to comment after postingJoey Hess
Jumping to the just posted comment was the imputus, but I killed a number of birds here. Added a INLINEPAGE template variable, which can be used to add anchors to any inline template. To keep that sufficiently general, it is the full page name, so the comment anchors and links changed form. Got rid of the FIXMEd hardcoded html anchor div. More importantly, the anchor is now to the very top of the comment, not the text below. So you can see the title, and how it attributes you. Avoid changing the permalink of pages that are not really comments, but happen to contain the _comment directive. I think that behavior was a bug, though not a likely one to occur since _comment should only really be used on comment pages.
2008-12-17jump to comments anchor after postJoey Hess
Not ideal, it would be nicer to jump to the actual comment posted, but no anchor is available.
2008-12-17typoJoey Hess
2008-12-17add Comments link when displaying a page inlineJoey Hess
This link will supplant the usual Discussion link for pages that have comments enabled.
2008-12-17fix test when comments_closed_pagespec is emptyJoey Hess
2008-12-17change around comments pagespecsJoey Hess
I think it is clearer to have one pagespec that controls all pages with comments, and a separate pagespec that can be used to close new comments on a subset of those pages.
2008-12-17fix default values for config settingsJoey Hess
defaults cannot be set in getsetup, do it in checkconfig to avoid uninitialized value warnings.
2008-12-17Coding style change: Remove explcit vim folding markers.Joey Hess
2008-12-17checksessionexpiry: reworkJoey Hess
This function as factored out was a bit confusing, I think this makes more sense.
2008-12-12elide unnecessary variablesJoey Hess
2008-12-12remove fixmeJoey Hess
sessioncgi hooks are always called with the wiki locked
2008-12-12fix redefinition of $authorJoey Hess
2008-12-12move related code togetherJoey Hess
2008-12-12whitespaceJoey Hess
2008-12-12don't explicitly use inlineJoey Hess
loadplugin("inline") should take care of that
2008-12-12avoid unnecessary variableJoey Hess
2008-12-12get rid of the [postcomment] hackJoey Hess
I think that using a flag variable is sorta cleaner. (This is untested.)
2008-12-12move getsetup to usual placeJoey Hess
2008-12-12comments: Store dates in GMT and in ISO-8601Simon McVittie
The [[!_comment]] directive is a serialization format, not something for presentation to users, so we should use the least ambiguous possible representation.
2008-12-11comments: Change internal-use-only directive from [[!comment]] to [[!_comment]]Simon McVittie
2008-12-11comments: Use new feedfile, emptyfeeds options to inlineSimon McVittie
2008-12-11comments: don't interpolate IP into anonymous user's "name"Simon McVittie
If an admin wants the IP in the comment display template they can still get it (the default template shows it).
2008-12-11comments: fix invocation of possibly_foolish_untaintSimon McVittie
2008-12-11comments: avoid warning if there's no subjectSimon McVittie
2008-12-11comments: Optionally allow anonymous commenters to set their name/URL.Simon McVittie
Also provide a way for the comment template to pick up the verified username/IP.
2008-12-11comments: Remove some dead codeSimon McVittie
2008-12-11comments: rename main field to "editcontent" consistent with editpageSimon McVittie
This has the side-effect that Ikiwiki's default style.css gives the text box 100% width.
2008-12-11comments: instead of hard-coding mdwn, allow any supported page formatSimon McVittie
2008-12-11comments: Save comments as a file with one big [[!comment]] directive.Simon McVittie
This delays all comment formatting until the last possible time, allows us to set metadata without worrying that commenters may be able to evade it, and means that changes to how a comment is saved can be handled gracefully. It also gives us somewhere to put the commenter's username or IP address for later reference.
2008-12-11Remove dead code for preprocessing [[!comments]]Simon McVittie
2008-12-11comments: Duplicate logic and CGI hook from recentchanges to link user pages ↵Simon McVittie
correctly
2008-12-11Qualify name of formattime() correctlySimon McVittie
2008-12-11Delay checking for session expiry til we actually post a commentSimon McVittie
2008-12-11comments: record the time at which each comment was postedSimon McVittie
2008-12-11comments: Use a checkconfig hook to get the default value of comments_pagenameSimon McVittie
2008-12-11comments: render comments/commenturl in page.tmplSimon McVittie
2008-12-11comments: use global config to decide whether commenting is allowed, and for ↵Simon McVittie
name of page Also: * decide comment page name sooner * set permalink on it
2008-12-11comments: use global configuration for allow_directives, commit, and pagenameSimon McVittie
2008-12-11comments: Add some global configurationSimon McVittie
2008-12-11comments: make preprocess a no-opSimon McVittie
2008-12-11comments: document what linkuser doesSimon McVittie
2008-12-11comments: add a stub pagetemplate hook to show the commentsSimon McVittie
2008-12-11comments: Use HTML entities to escape directivesSimon McVittie
2008-12-11Embed comments into comments_embed.tmpl rather than concatenating in perlSimon McVittie
2008-12-11comments: use CGI module's checksessionexpirySimon McVittie
2008-12-11comments: remove allowhtml option, just switch it on all the timeSimon McVittie
Now that posts are individually sanitized, that should be safe.
2008-12-11comments: load inline and mdwn lazilySimon McVittie
2008-12-11comments: don't rely on mdwn getting loaded firstSimon McVittie
2008-12-11comments: sanitize the body of each comment before posting itSimon McVittie
This should ensure that users can't "break out" from the enclosing <div>, making it impossible to forge comments (assuming htmlscrubber is enabled, and so is either htmlbalance or htmltidy).