Age | Commit message (Collapse) | Author | |
---|---|---|---|
2008-07-25 | Merge branch 'master' into autoconfig | Joey Hess | |
2008-07-25 | attachment: Use relative paths when inserting links. | Joey Hess | |
2008-07-25 | added getsetup hooks for all plugins up to recentchanges | Joey Hess | |
2008-07-23 | foldage | Joey Hess | |
2008-07-23 | Merge branch 'master' into tova | Joey Hess | |
2008-07-23 | attachment: Do not escape _ when determining attachment filenames. | Joey Hess | |
2008-07-22 | Don't allow uploading an attachment with the same name as an existing page, ↵ | Joey Hess | |
to avoid confusion. | |||
2008-07-22 | make message a bit more generic | Joey Hess | |
2008-07-22 | avoid uninitialised value | Joey Hess | |
2008-07-21 | factor out check_canattach | Joey Hess | |
Other plugins will need to use this. | |||
2008-07-09 | improve error message if virus checker fails w/o output | Joey Hess | |
2008-07-08 | attachment: Support perl 5.8's buggy version of CGI.pm. | Joey Hess | |
This is truely horribly disgusting. CGI::tmpFileName, in current perls, is an undocumented function (which should be a clue..) that takes the original filename of an uploaded attachment, and returns the name of the tempfile that CGI has stored it in. In old perls, though, CGI::tmpFileName does not take a filename. It takes a key from the object's {'.tmpfiles'} hash. This key is something crazy like '*Fh::fh00001group' -- apparently the stringification of a filehandle object. Just to add to the fun, tmpFileName doesn't take the key, it expects a refernce to the key. Argh?! But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken in two other ways. The upload() method is supposed to return a filehandle to the temp file. It doesn't. The param() method is supposed to return a filehandle to the temp file, that stringifies to the original filename. It returns just the original filename, no filehandle. Combine all these bugs, and you end up with this disgusting commit. Since I have no way to get the filehandle, I *need* to get the tempfile name. If I had the filehandle, I could probably pass it into tmpFileName, and it might strigify to the right key name. But I don't, so the only way to determine the key is to grub through the .tmpfiles hash ourselves. And finally, one the temp file name is discovered, a filehandle can finally be obtained by (re)opening it. I recommend that this commit be reverted when perl 5.8 is a mercifully faded memory. I'm really, really, really glad I'm actually being paid for working on this right now! | |||
2008-07-08 | explicitly set form type to multipart | Joey Hess | |
This is the default in unstable's formbuilder, but not in stable's, and CGI multipart is needed for fule uploads. | |||
2008-07-08 | check for tempfile being empty | Joey Hess | |
2008-07-08 | undef $fh before opening | Joey Hess | |
2008-07-08 | another try at dealing with CGI.pm problem | Joey Hess | |
open the temp file if all attempts to get a fd fail | |||
2008-07-08 | attachment: Support old versions of CGI.pm that lack an upload method. | Joey Hess | |
2008-07-08 | attachment: Fix an uninitialised value warning when editing a page that ↵ | Joey Hess | |
currently has no attachments. | |||
2008-07-06 | add virus checking to attachments plugin | Joey Hess | |
2008-07-06 | avoid uninitialised value warnings | Joey Hess | |
2008-07-02 | link to pagespec/attachment | Joey Hess | |
2008-07-02 | factor out glob2re | Joey Hess | |
2008-07-02 | add mimetype checking | Joey Hess | |
2008-07-02 | add user and ip support to attachment pagespecs | Joey Hess | |
2008-07-02 | xhtml fixes | Joey Hess | |
2008-07-02 | attachments interface visibility toggling | Joey Hess | |
2008-07-01 | fixes | Joey Hess | |
2008-07-01 | some fit and finish fixes | Joey Hess | |
2008-07-01 | only show one sig fig | Joey Hess | |
2008-07-01 | display human sizes | Joey Hess | |
2008-07-01 | add both kinds of links | Joey Hess | |
2008-07-01 | basic attachment list | Joey Hess | |
2008-07-01 | save attachments when page is saved too | Joey Hess | |
A user might specify an attachment, but not click the upload button, and just save the whole page instead. | |||
2008-07-01 | check attachments in and refresh | Joey Hess | |
2008-07-01 | add allowed attachments field to admin prefs | Joey Hess | |
2008-07-01 | fix expensive move code path | Joey Hess | |
2008-07-01 | better approach for cgi upload disabling | Joey Hess | |
Make it a config setting, this way subtle load order issues don't come into play. (As much?) | |||
2008-07-01 | bugfixes | Joey Hess | |
2008-07-01 | attachment location | Joey Hess | |
Put the attachment in a subdir of the page it's attached to, unless that page is an "index" page. | |||
2008-07-01 | reorder | Joey Hess | |
canedit should fail first as it's a less expensive and harder to pass test | |||
2008-07-01 | call check_canedit | Joey Hess | |
Needed to prevent uploads of locked pages as attachments. | |||
2008-07-01 | bugfix; support pagetype of "0" | Joey Hess | |
2008-07-01 | copy the attachment into srcdir | Joey Hess | |
2008-06-30 | fix some messages | Joey Hess | |
2008-06-30 | add an ispage limit | Joey Hess | |
2008-06-30 | minor improvements | Joey Hess | |
2008-06-30 | basic attachment plugin, unfinished | Joey Hess | |
Currently includes UI, and a few tests of the attachment, as well as the framework to extend pagespecs to test attachments. Does not actually save the file yet. |