Age | Commit message (Collapse) | Author | |
---|---|---|---|
2010-04-21 | update; my branch is (partially) debugged now | Joey Hess | |
2010-04-21 | debugging | http://hendry.iki.fi/ | |
2010-04-21 | remove verify_src_file | Joey Hess | |
Splitting out this function bothered me. It is conceptially similar to file_pruned, and yet also very specific to exactly the security needs of find_src_files. I liked that it got rid of duplicate code in the latter function. So instead, put a helper sub in that, which I think allows refactoring things more cleanly, and with less boilerplate. As to the needs of gen_autofile, I'm not convinced this needs to handle the same set of problems that verify_src_file did. So I sat down and wrote a custom validator for autofiles, which turned out to seem to just need three things: Make sure the candidate filename is not something that would be pruned; untaint the candidate filename; and make sure that srcdir doesn't already have something with its name. (Plus, of course, all the other checks that were already in gen_autofile.) (In passing, also fixed a bunch of bugs I had introduced in this branch.) | |||
2010-04-21 | add_autofile filename should be relative to srcdir | Joey Hess | |
2010-04-21 | Merge branch 'master' into autotag | Joey Hess | |
2010-04-21 | applied | Joey Hess | |
2010-04-21 | layout | Joey Hess | |
2010-04-21 | Always give createlink class to links to nonexistent pages | Giuseppe Bilotta | |
With this change, the <span> with class createlink is always created around the link text, even when no CGI URL is defined. This allows styling of these 'links' in this case too. The same class is used as when CGI URL is defined so that e.g. clones of the same ikiwiki, one with CGI and one without, display in the same way (modulo the missing question mark link). (cherry picked from commit 290d1b498f00f63e6d41218ddb76d87e68ed5081) | |||
2010-04-21 | Missing links with no CGI | http://oblomov.myopenid.com/ | |
2010-04-20 | Merge branch 'master' into autotag | Joey Hess | |
2010-04-20 | Merge branch 'file_pruned_revamp' | Joey Hess | |
2010-04-20 | bugfix | Joey Hess | |
So this is the one place that does need to canonpath and compare, as two argument file_pruned used to. | |||
2010-04-20 | Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info | Joey Hess | |
2010-04-20 | darcs: ensure whole darcs query manifest output is consumed | Joey Hess | |
By a stroke of luck, after a long & full day, I happened to remember that in the morning, I had seen someone on irc mention that darcs query manifest doesn't like it if its full output is not consumed. So contrary to the usual case where bug reports sent via irc are like messages written in sand before the new tide, this one was seen and fixed. (But use http://ikiwiki.info/bugs/ next time!) | |||
2010-04-20 | bugfix | Joey Hess | |
Avoid file_pruned triggering on absolute paths causing the whole comments_pending directory being pruned. Simplify code. | |||
2010-04-20 | Merge branch 'master' into file_pruned_revamp | Joey Hess | |
2010-04-20 | fix uninitialized value warning | Joey Hess | |
$cgi->params('do') may not be defined. The CSRF code may delete all cgi params. This uninitalized value was introduced when do=register support was added recently. | |||
2010-04-20 | Clarifications | http://oblomov.myopenid.com/ | |
2010-04-20 | typo | Joey Hess | |
2010-04-20 | fix stat to use unmunged filename | Joey Hess | |
2010-04-20 | oops, fix for no_chdir mode | Joey Hess | |
$_ will be absolute then | |||
2010-04-20 | remove 2 argument form of file_pruned | Joey Hess | |
2010-04-20 | switch to 1 parameter version of file_pruned | Joey Hess | |
Another bit of code that didn't realize that File::Find sets $_ to the relative filename. | |||
2010-04-20 | remove explicit absolute test | Joey Hess | |
file_pruned now tests for that | |||
2010-04-20 | use one parameter form of file_pruned here too | Joey Hess | |
In File::Find, $_ is relative to the current directory, so that is ok. Also, the directory name doesn't need to be stripped from $_. | |||
2010-04-20 | clarify why absolute is tested & stripped here | Joey Hess | |
file_prune also fails on absolute filenames now | |||
2010-04-20 | Merge branch 'master' into file_pruned_revamp | Joey Hess | |
2010-04-20 | internal pages: the revenge? | http://smcv.pseudorandom.co.uk/ | |
2010-04-20 | clarify whether the raw files would be put in destdir | Jon Dowland | |
2010-04-20 | fix minor bug if a page's name is "0" | Joey Hess | |
2010-04-20 | similarity to internal pages | Joey Hess | |
2010-04-20 | no need to return content from postscan hook | Joey Hess | |
2010-04-19 | response | Joey Hess | |
2010-04-19 | Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info | Joey Hess | |
2010-04-19 | change wording | Joey Hess | |
This is more accurate when a file that is not a page is what is removed. | |||
2010-04-20 | non comprend | http://kerravonsen.dreamwidth.org/ | |
2010-04-20 | formatting | http://kerravonsen.dreamwidth.org/ | |
2010-04-20 | further clarification | http://kerravonsen.dreamwidth.org/ | |
2010-04-19 | response | Joey Hess | |
2010-04-19 | Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info | Joey Hess | |
2010-04-20 | response | http://kerravonsen.dreamwidth.org/ | |
2010-04-19 | Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info | Joey Hess | |
2010-04-19 | move message into if block | Joey Hess | |
2010-04-19 | Merge branch 'master' of git://git.ikiwiki.info | Svend Sorensen | |
2010-04-19 | Remove www prefix from Svend's website URLs | Svend Sorensen | |
2010-04-19 | Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info | Joey Hess | |
2010-04-19 | thinking about changing how templatedir works and allowing wikitemplate ↵ | Joey Hess | |
files into the srcdir | |||
2010-04-19 | Respond | http://oblomov.myopenid.com/ | |
2010-04-19 | response to the further thoughts | http://kerravonsen.dreamwidth.org/ | |
2010-04-18 | (no commit message) | PeteG | |