summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2008-07-09web commit by http://jcflack.myopenid.com/Joey Hess
2008-07-09web commit by http://jcflack.myopenid.com/Joey Hess
2008-07-09web commit by http://ptecza.myopenid.com/: * Confirmation and thanksJoey Hess
2008-07-09remove patch tagJoey Hess
2008-07-09closeJoey Hess
2008-07-09closeJoey Hess
2008-07-09Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.infoJoey Hess
2008-07-09testingJoey Hess
2008-07-09web commit by bremner: fix my nameJoey Hess
2008-07-08mention github mirrorJoey Hess
2008-07-08testingJoey Hess
2008-07-08testingJoey Hess
2008-07-08testingJoey Hess
2008-07-08testingJoey Hess
2008-07-08testingJoey Hess
2008-07-08otl: Support utf-8 files. (Recai Oktaş)Joey Hess
2008-07-08responseJoey Hess
2008-07-08web commit by https://id.mayfirst.org/jamie/Joey Hess
2008-07-08web commit by https://id.mayfirst.org/jamie/Joey Hess
2008-07-08responseJoey Hess
2008-07-08web commit by AndrewGreenberg: bad formatting on bug report, sorry.Joey Hess
2008-07-08web commit by AndrewGreenberg: Added nasty URL edit bug in 2.52.Joey Hess
2008-07-08not yet releasedJoey Hess
2008-07-08responseJoey Hess
2008-07-08web commit by mrledJoey Hess
2008-07-08Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.infoJoey Hess
Conflicts: doc/bugs/attachment:_failed_to_get_filehandle.mdwn
2008-07-08attachment: Support perl 5.8's buggy version of CGI.pm.Joey Hess
This is truely horribly disgusting. CGI::tmpFileName, in current perls, is an undocumented function (which should be a clue..) that takes the original filename of an uploaded attachment, and returns the name of the tempfile that CGI has stored it in. In old perls, though, CGI::tmpFileName does not take a filename. It takes a key from the object's {'.tmpfiles'} hash. This key is something crazy like '*Fh::fh00001group' -- apparently the stringification of a filehandle object. Just to add to the fun, tmpFileName doesn't take the key, it expects a refernce to the key. Argh?! But the fun doesn't stop there, because in perl 5.8, CGI.pm is also broken in two other ways. The upload() method is supposed to return a filehandle to the temp file. It doesn't. The param() method is supposed to return a filehandle to the temp file, that stringifies to the original filename. It returns just the original filename, no filehandle. Combine all these bugs, and you end up with this disgusting commit. Since I have no way to get the filehandle, I *need* to get the tempfile name. If I had the filehandle, I could probably pass it into tmpFileName, and it might strigify to the right key name. But I don't, so the only way to determine the key is to grub through the .tmpfiles hash ourselves. And finally, one the temp file name is discovered, a filehandle can finally be obtained by (re)opening it. I recommend that this commit be reverted when perl 5.8 is a mercifully faded memory. I'm really, really, really glad I'm actually being paid for working on this right now!
2008-07-08explicitly set form type to multipartJoey Hess
This is the default in unstable's formbuilder, but not in stable's, and CGI multipart is needed for fule uploads.
2008-07-08Include ikiwiki.setup in examples in the debian package.Joey Hess
2008-07-08web commit by http://ptecza.myopenid.com/: * Thanks!Joey Hess
2008-07-08web commit by HenrikBrixAndersen: This happens on FreeBSD as wellJoey Hess
2008-07-08reproducedJoey Hess
2008-07-08responseJoey Hess
2008-07-08check for tempfile being emptyJoey Hess
2008-07-08rmJoey Hess
2008-07-08web commit by http://ptecza.myopenid.com/: * The bug still occursJoey Hess
2008-07-08add dist-bugsJoey Hess
2008-07-08mergeJoey Hess
2008-07-08responseJoey Hess
2008-07-08web commit by mrledJoey Hess
2008-07-08web commit by mrledJoey Hess
2008-07-08web commit by mrledJoey Hess
2008-07-08web commit by mrledJoey Hess
2008-07-08web commit by mrledJoey Hess
2008-07-08undef $fh before openingJoey Hess
2008-07-08web commit by http://ptecza.myopenid.com/: * Still no successJoey Hess
2008-07-08responseJoey Hess
2008-07-08another try at dealing with CGI.pm problemJoey Hess
open the temp file if all attempts to get a fd fail
2008-07-08web commit by http://ptecza.myopenid.com/: * Debugging againJoey Hess
2008-07-08possible fixJoey Hess
generated by cgit v1.2.3 (git 2.46.0) at 2024-12-23 04:57:51 +0000