summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2008-04-10web commit by cjb: Added wiktionary shortcutJoey Hess
2008-04-10web commit by http://sabr.myopenid.com/Joey Hess
2008-04-10responseJoey Hess
2008-04-10cannot reproduceJoey Hess
2008-04-10responseJoey Hess
2008-04-10let's move the access keys discussion out to the todo item about itJoey Hess
2008-04-10correct the command line used to generate the faviconJoey Hess
2008-04-10correct utf-8 damage introduced by jblevins's modification of this pageJoey Hess
2008-04-10change wordingJoey Hess
2008-04-10responseJoey Hess
2008-04-10Give the full path to the hyperestraier helpfile in estseek.conf.Joey Hess
2008-04-10Use bzr --quiet to avoid it outputting stuff and messing up http headers. ↵Joey Hess
(Scott Bronson)
2008-04-10Fix broken rcs_update for bzr. (Scott Bronson)Joey Hess
2008-04-10Fix missing import of escapeHTML in userlink. (Scott Bronson)Joey Hess
2008-04-10responseJoey Hess
2008-04-10add news item for ikiwiki 2.42Joey Hess
2008-04-10releasing version 2.42Joey Hess
2008-04-10Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.infoJoey Hess
2008-04-10perl dumping core is not an ikiwiki bug, sorryJoey Hess
2008-04-10web commit by http://joey.kitenet.net/: testJoey Hess
2008-04-10Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.infoJoey Hess
2008-04-10Fix CSRF attacks against the preferences and edit forms. Closes: #475445Joey Hess
The fix involved embedding the session id in the forms, and not allowing the forms to be submitted if the embedded id does not match the session id. In the case of the preferences form, if the session id is not embedded, then the CGI parameters are cleared. This avoids a secondary attack where the link to the preferences form prefills password or other fields, and the user hits "submit" without noticing these prefilled values. In the case of the editpage form, the anonok plugin can allow anyone to edit, and so I chose not to guard against CSRF attacks against users who are not logged in. Otherwise, it also embeds the session id and checks it. For page editing, I assume that the user will notice if content or commit message is changed because of CGI parameters, and won't blndly hit save page. So I didn't block those CGI paramters. (It's even possible to use those CGI parameters, for good, not for evil, I guess..) The only other CSRF attack I can think of in ikiwiki involves the poll plugin. It's certianly possible to set up a link that causes the user to unknowingly vote in a poll. However, the poll plugin is not intended to be used for things that people would want to attack, since anyone can after all edit the poll page and fill in any values they like. So this "attack" is ignorable.
2008-04-10fix what I think is a typoJoey Hess
2008-04-10web commit by http://joey.kitenet.net/: oops :-)Joey Hess
2008-04-10web commit by http://joey.kitenet.net/Joey Hess
2008-04-10web commit by ScottSwalwell: Fixed my fix.Joey Hess
2008-04-10web commit by ScottSwalwell: Fixed this link.Joey Hess
2008-04-10web commit by cjb: Fixed URLJoey Hess
2008-04-10web commit by cjb: TaggedJoey Hess
2008-04-10web commit by cjb: Suggested patch for 302 redirect after page creation when ↵Joey Hess
using bzr
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/: poll vote (Accept only OpenID for ↵Joey Hess
logins)
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-09web commit by http://sabr.myopenid.com/Joey Hess
2008-04-08web commit by ittaydJoey Hess
2008-04-08web commit by http://sabr.myopenid.com/Joey Hess
2008-04-08web commit by http://sabr.myopenid.com/Joey Hess
2008-04-08web commit by http://sabr.myopenid.com/Joey Hess