diff options
Diffstat (limited to 'doc')
-rw-r--r-- | doc/bugs/Comments_link_is_to_index.html_if_usedirs_is_on.mdwn | 5 | ||||
-rw-r--r-- | doc/bugs/beautify__95__urlpath_will_add_.__47___even_if_it_is_already_present.mdwn | 3 | ||||
-rw-r--r-- | doc/style.css | 1 | ||||
-rw-r--r-- | doc/todo/Improve_display_of_OpenIDs.mdwn | 5 | ||||
-rw-r--r-- | doc/todo/comments.mdwn | 71 | ||||
-rw-r--r-- | doc/wikiicons/anonymous.png | bin | 302 -> 0 bytes | |||
-rw-r--r-- | doc/wikiicons/openid.png | bin | 297 -> 0 bytes | |||
-rw-r--r-- | doc/wikiicons/signedin.png | bin | 370 -> 0 bytes |
8 files changed, 52 insertions, 33 deletions
diff --git a/doc/bugs/Comments_link_is_to_index.html_if_usedirs_is_on.mdwn b/doc/bugs/Comments_link_is_to_index.html_if_usedirs_is_on.mdwn new file mode 100644 index 000000000..6df3ccd9c --- /dev/null +++ b/doc/bugs/Comments_link_is_to_index.html_if_usedirs_is_on.mdwn @@ -0,0 +1,5 @@ +When a page links to its own #comments anchor you get a link like +"index.html#comments" rather than "./#comments". Fixed in commit 0844bd0b +on my 'comments' branch. --[[smcv]] + +[[!tag patch done]] diff --git a/doc/bugs/beautify__95__urlpath_will_add_.__47___even_if_it_is_already_present.mdwn b/doc/bugs/beautify__95__urlpath_will_add_.__47___even_if_it_is_already_present.mdwn new file mode 100644 index 000000000..8e96b1f56 --- /dev/null +++ b/doc/bugs/beautify__95__urlpath_will_add_.__47___even_if_it_is_already_present.mdwn @@ -0,0 +1,3 @@ +beautify_urlpath will prepend a useless "./" to the URL "./foo". Fixed in commit 5b1cf21a on my comments branch. --[[smcv]] + +[[!tag patch done]] diff --git a/doc/style.css b/doc/style.css index 1fabf6b29..81a260afd 100644 --- a/doc/style.css +++ b/doc/style.css @@ -375,6 +375,7 @@ span.color { .comment-header { font-style: italic; + margin-top: .3em; } .comment .author { font-weight: bold; diff --git a/doc/todo/Improve_display_of_OpenIDs.mdwn b/doc/todo/Improve_display_of_OpenIDs.mdwn new file mode 100644 index 000000000..9c21e8234 --- /dev/null +++ b/doc/todo/Improve_display_of_OpenIDs.mdwn @@ -0,0 +1,5 @@ +Some OpenIDs seen in the IkiWiki git history are displayed poorly in [[RecentChanges]], including mine :-) (`http://smcv.pseudorandom.co.uk/`, shown as `smcv.pseudorandom [co.uk]`) + +My `openid` branch on <http://git.pseudorandom.co.uk/> improves on a couple of cases and adds a regression test. --[[smcv]] + +[[!tag patch]] diff --git a/doc/todo/comments.mdwn b/doc/todo/comments.mdwn index 7e35a2619..bab46a0b2 100644 --- a/doc/todo/comments.mdwn +++ b/doc/todo/comments.mdwn @@ -18,11 +18,43 @@ > Won't the remove plugin refuse to remove internal pages? This would be > a good feature to have, though. --[[smcv]] -* Now that inline has some comments-specific functionality anyway, it would - be good to output `<link rel="comments">` in Atom and the equivalent in RSS. - ## Patches pending merge +* There is some common code cargo-culted from other plugins (notably inline and editpage) which + should probably be shared + + > Actually, there's less of this now than there used to be - a lot of simple + > things that were shared have become unshareable as they became more + > complex. --[[smcv]] + + > There's still goto. You have a branch for that. --[[Joey]] + +## Won't fix + +* It would be useful to have a pagespec that always matches all comments on + pages matching a glob. Something like `comment(blog/*)`. + Perhaps postcomment could also be folded into this? Then the pagespec + would match both existing comments, as well as new comments that are + being posted. + + > Please see [[plugins/comments/discussion]]. If I've convinced you that + > internal pages are the way forward, then sure, we can do that, because + > people who can comment still won't be able to edit others' comments + > (one of my goals is that commenters can't put words into each other's + > mouths :-) ) + > + > On the other hand, if you still want me to switch this plugin to "real" + > pages, or if internal pages might become editable in future, then + > configuring lockedit/anonok so a user X can add comments to blog pages + > would also let X edit/delete comments on blog pages (including those + > written by others) in arbitrary ways, which doesn't seem good. --[[smcv]] + + > I had a look at implementing comment() and fell afoul of + > some optimisations that assume only internal() will be used to match + > internal pages. So probably this isn't worth doing. --[[Joey]] + +## Done + * The default template should have a (?) icon next to unauthenticated users (with the IP address as title) and an OpenID icon next to OpenIDs @@ -67,38 +99,11 @@ > and c42f174e fix another `beautify_urlpath` bug and add a regression test > --[[smcv]] -## Won't fix - -* There is some common code cargo-culted from other plugins (notably inline and editpage) which - should probably be shared - - > Actually, there's less of this now than there used to be - a lot of simple - > things that were shared have become unshareable as they became more - > complex. --[[smcv]] - -* It would be useful to have a pagespec that always matches all comments on - pages matching a glob. Something like `comment(blog/*)`. - Perhaps postcomment could also be folded into this? Then the pagespec - would match both existing comments, as well as new comments that are - being posted. - - > Please see [[plugins/comments/discussion]]. If I've convinced you that - > internal pages are the way forward, then sure, we can do that, because - > people who can comment still won't be able to edit others' comments - > (one of my goals is that commenters can't put words into each other's - > mouths :-) ) - > - > On the other hand, if you still want me to switch this plugin to "real" - > pages, or if internal pages might become editable in future, then - > configuring lockedit/anonok so a user X can add comments to blog pages - > would also let X edit/delete comments on blog pages (including those - > written by others) in arbitrary ways, which doesn't seem good. --[[smcv]] +* Now that inline has some comments-specific functionality anyway, it would + be good to output `<link rel="comments">` in Atom and the equivalent in RSS. - > I had a look at implementing comment() and fell afoul of - > some optimisations that assume only internal() will be used to match - > internal pages. So probably this isn't worth doing. --[[Joey]] + > Fixed in my comments branch by d0d598e4, 3feebe31, 9e5f504e --[[smcv]] -## Done * Add `COMMENTOPENID`: the authenticated/verified user name, if and only if it was an OpenID diff --git a/doc/wikiicons/anonymous.png b/doc/wikiicons/anonymous.png Binary files differdeleted file mode 100644 index df22152e6..000000000 --- a/doc/wikiicons/anonymous.png +++ /dev/null diff --git a/doc/wikiicons/openid.png b/doc/wikiicons/openid.png Binary files differdeleted file mode 100644 index c5535c3de..000000000 --- a/doc/wikiicons/openid.png +++ /dev/null diff --git a/doc/wikiicons/signedin.png b/doc/wikiicons/signedin.png Binary files differdeleted file mode 100644 index 969908d39..000000000 --- a/doc/wikiicons/signedin.png +++ /dev/null |