diff options
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/plugins/comments.mdwn | 12 | ||||
| -rw-r--r-- | doc/plugins/comments/discussion.mdwn | 3 | ||||
| -rw-r--r-- | doc/todo/comments.mdwn | 8 | ||||
| -rw-r--r-- | doc/todo/supporting_comments_via_disussion_pages.mdwn | 3 |
4 files changed, 14 insertions, 12 deletions
diff --git a/doc/plugins/comments.mdwn b/doc/plugins/comments.mdwn index fa263ef40..aab75e9b7 100644 --- a/doc/plugins/comments.mdwn +++ b/doc/plugins/comments.mdwn @@ -37,15 +37,3 @@ There are some global options for the setup file: specify a name for themselves, and the \[[!meta author]] and \[[!meta authorurl]] directives will not be overridden by the comments plugin - -Known issues: - -* Needs code review -* The access control via postcomment() is rather strange (see [[discussion]] for more details) -* There is some common code cargo-culted from other plugins (notably inline and editpage) which - should probably be shared -* Joey doesn't think it should necessarily use internal pages (see [[discussion]]) -* Previews always say "unknown IP address" -* Add `COMMENTOPENID`: the authenticated/verified user name, if and only if it was an OpenID -* The default template should have a (?) icon next to unauthenticated users (with the IP address - as title) and an OpenID icon next to OpenIDs diff --git a/doc/plugins/comments/discussion.mdwn b/doc/plugins/comments/discussion.mdwn index 59740ec37..2a87a3d93 100644 --- a/doc/plugins/comments/discussion.mdwn +++ b/doc/plugins/comments/discussion.mdwn @@ -63,6 +63,9 @@ spam problems. So, use `check_canedit` as at least a first-level check? > This is why `anonok_pages => 'postcomment(*)'` and `locked_pages => '!postcomment(*)'` > are necessary to allow anonymous and logged-in editing (respectively). > +>> I changed that to move the flag out of the page name, and into a variable that the `match_postcomment` +>> function checks for. Other ugliness still applies. :-) --[[Joey]] +> > This is ugly - one alternative would be to add `check_permission()` that takes a > page and a verb (create, edit, rename, remove and maybe comment are the ones I > can think of so far), use that, and port the plugins you mentioned to use that diff --git a/doc/todo/comments.mdwn b/doc/todo/comments.mdwn new file mode 100644 index 000000000..adc302a25 --- /dev/null +++ b/doc/todo/comments.mdwn @@ -0,0 +1,8 @@ +Known issues with the [[plugins/comments]] plugin: + +* There is some common code cargo-culted from other plugins (notably inline and editpage) which + should probably be shared +* Previews always say "unknown IP address" +* Add `COMMENTOPENID`: the authenticated/verified user name, if and only if it was an OpenID +* The default template should have a (?) icon next to unauthenticated users (with the IP address + as title) and an OpenID icon next to OpenIDs diff --git a/doc/todo/supporting_comments_via_disussion_pages.mdwn b/doc/todo/supporting_comments_via_disussion_pages.mdwn index bc4e331d0..892db18a9 100644 --- a/doc/todo/supporting_comments_via_disussion_pages.mdwn +++ b/doc/todo/supporting_comments_via_disussion_pages.mdwn @@ -215,3 +215,6 @@ do you think so far? Known issues include: --[[smcv]] I've updated smcvpostcomment and publicised it as [[plugins/contrib/comments]]. --[[smcv]] + +> While there is still room for improvement and entirely other approaches, +> I am calling this done since smcv's comments plugin is ready. --[[Joey]] |