diff options
Diffstat (limited to 'doc/plugins/map/discussion.mdwn')
| -rw-r--r-- | doc/plugins/map/discussion.mdwn | 29 |
1 files changed, 29 insertions, 0 deletions
diff --git a/doc/plugins/map/discussion.mdwn b/doc/plugins/map/discussion.mdwn index c724a6492..2f7b140d6 100644 --- a/doc/plugins/map/discussion.mdwn +++ b/doc/plugins/map/discussion.mdwn @@ -18,3 +18,32 @@ We'd also very much like to have an option to display the title of the page inst There's a patch implementing this in [[!debbug 484510]]. It needs a few fixes before I merge it. Now applied. --[[Joey]] + +---- + +I noticed that when the pagespec returns no map items, the map plugin does not close off the ul and div tags. Below is a simple patch +that seems to work on the examples I tried. I am a beginner so please help me out here. Thanks. --[[harishcm]] + + --- a/map.pm + +++ b/map.pm + @@ -81,6 +81,13 @@ + my $openli=0; + my $addparent=""; + my $map = "<div class='map'>\n<ul>\n"; + + + + # Return properly closed $map if %mapitems is empty + + if (!scalar(keys %mapitems)) { + + $map .= "</ul>\n</div>\n"; + + return $map; + + } + + + foreach my $item (sort keys %mapitems) { + my @linktext = (length $mapitems{$item} ? (linktext => $mapitems{$item}) : ()); + $item=~s/^\Q$common_prefix\E\/// + +> This was also reported as [[bugs/map_fails_to_close_ul_element_for_empty_list]]; +> this patch is simpler than the one there, but has the same problem (it emits +> `<ul></ul>`, which technically isn't valid HTML either). --[[smcv]] + +>> Thanks for the tip, I added another patch addressing the issue at +>> [[bugs/map_fails_to_close_ul_element_for_empty_list]]. --[[harishcm]] |