diff options
Diffstat (limited to 'doc/bugs')
5 files changed, 68 insertions, 6 deletions
diff --git a/doc/bugs/entirely_negated_pagespec_matches_internal_pages.mdwn b/doc/bugs/entirely_negated_pagespec_matches_internal_pages.mdwn index 02ce4e221..a9b223a46 100644 --- a/doc/bugs/entirely_negated_pagespec_matches_internal_pages.mdwn +++ b/doc/bugs/entirely_negated_pagespec_matches_internal_pages.mdwn @@ -21,3 +21,10 @@ pagespec, and implicitly add "and !internal()" to it. Either approach would require fully parsing the pagespec. And consider cases like "!(foo and !bar)". Doesn't seem at all easy to solve. --[[Joey]] + +> It occurs to me that at least one place in ikiwiki optimizes by assuming +> that pagespecs not mentioning the word "internal" never match internal +> pages. I wonder whether this bug could be solved by making that part of +> the definition of a pagespec, rather than a risky optimization +> like it is now? That seems strange, though - having this special case +> would make pagespecs significantly harder to understand. --[[smcv]] diff --git a/doc/bugs/html5_support.mdwn b/doc/bugs/html5_support.mdwn index 09ded91da..783f5e47c 100644 --- a/doc/bugs/html5_support.mdwn +++ b/doc/bugs/html5_support.mdwn @@ -3,8 +3,15 @@ Some elements of safely supported by ikiwiki. There are [several differences between HTML4 and HTML5](http://www.w3.org/TR/html5-diff/). +[[!template id=gitbranch branch=hendry/html5 author="[[Kai_Hendry|hendry]]"]] + * [HTML5 branch](http://git.webconverger.org/?p=ikiwiki;h=refs/heads/html5) * [ikiwiki instance with HTML5 templates](http://natalian.org) +* [HTML5 outliner tool](http://gsnedders.html5.org/outliner/) -- to check you have the structure of your markup correct + +# htmlscrubber.pm needs to not scrub new HTML5 elements + +* [new elements](http://www.w3.org/TR/html5-diff/#new-elements) # HTML5 Validation and t/html.t @@ -28,9 +35,9 @@ This element is poorly supported by browsers. As a workaround, `style.css` needs display: block; } -Internet Explorer will display it as a block, though you can't seem to be further control the style. +Internet Explorer will display it as a block, though you can't seem to be able to further control the style. -# Validator complains with no h1-h6 in header +# Validator complains about no h1-h6 in header * [#509](http://bugzilla.validator.nu/show_bug.cgi?id=509) diff --git a/doc/bugs/map_fails_to_close_ul_element_for_empty_list.mdwn b/doc/bugs/map_fails_to_close_ul_element_for_empty_list.mdwn index 0edba438c..0a67934aa 100644 --- a/doc/bugs/map_fails_to_close_ul_element_for_empty_list.mdwn +++ b/doc/bugs/map_fails_to_close_ul_element_for_empty_list.mdwn @@ -1,3 +1,5 @@ +[[!tag plugins/map patch]] + input: before. @@ -13,7 +15,7 @@ Presuming that the pagespec does not match, output: The UL element is not closed. -Patch[[!tag patch]]: +Patch: --- /usr/share/perl5/IkiWiki/Plugin/map.pm 2009-05-06 00:56:55.000000000 +0100 +++ IkiWiki/Plugin/map.pm 2009-06-15 12:23:54.000000000 +0100 @@ -45,3 +47,47 @@ Patch[[!tag patch]]: >> be regression-test friendly but I might have a go at reworking it. With >> this variety of problem I have a strong inclination to use HOFs like map, >> grep. - [[Jon]] + +>>> The patch in [[map/discussion|plugins/map/discussion]] has the same +>>> problem, but does suggest a simpler approach to solving it (bail out +>>> early if the map has no items at all). --[[smcv]] + +>>>> Thanks for pointing out the problem. I guess this patch should solve it. +>>>> --[[harishcm]] + +>>>>> Well, I suppose that's certainly a minimal patch for this bug :-) +>>>>> I'm not the IkiWiki maintainer, but if I was, I'd apply it, so I've put +>>>>> it in a git branch for Joey's convenience. Joey, Jon: any opinion? +>>>>> +>>>>> If you want to be credited for this patch under a name other than +>>>>> "harishcm" (e.g. your real name), let me know and I'll amend the branch. +>>>>> (Or, make a git branch of your own and replace the reference just below, +>>>>> if you prefer.) --[[smcv]] + +>>>>>> The current arrangement looks fine to me. Thanks. --[[harishcm]] + +[[!template id=gitbranch author="[[harishcm]]" branch=smcv/ready/harishcm-map-fix]] + +Patch: + + --- /usr/local/share/perl/5.8.8/IkiWiki/Plugin/map.pm + +++ map.pm + @@ -80,7 +80,17 @@ + my $indent=0; + my $openli=0; + my $addparent=""; + - my $map = "<div class='map'>\n<ul>\n"; + + my $map = "<div class='map'>\n"; + + + + # Return empty div if %mapitems is empty + + if (!scalar(keys %mapitems)) { + + $map .= "</div>\n"; + + return $map; + + } + + else { # continue populating $map + + $map .= "<ul>\n"; + + } + + + foreach my $item (sort keys %mapitems) { + my @linktext = (length $mapitems{$item} ? (linktext => $mapitems{$item}) : ()); + $item=~s/^\Q$common_prefix\E\/// diff --git a/doc/bugs/pagetitle_function_does_not_respect_meta_titles.mdwn b/doc/bugs/pagetitle_function_does_not_respect_meta_titles.mdwn index 042d6a20c..be14e5126 100644 --- a/doc/bugs/pagetitle_function_does_not_respect_meta_titles.mdwn +++ b/doc/bugs/pagetitle_function_does_not_respect_meta_titles.mdwn @@ -1,3 +1,5 @@ +[[!tag patch plugins/inline patch/core]] + The `IkiWiki::pagetitle` function does not respect title changes via `meta.title`. It really should, so that links rendered with `htmllink` get the proper title in the link text. --[[madduck]] @@ -5,7 +7,7 @@ The `IkiWiki::pagetitle` function does not respect title changes via `meta.title ---- It is possible to set a Page-Title in the meta-plugin, but that one isn't -reused in parentlinks. This [[patch]] may fix it. +reused in parentlinks. This patch may fix it. <ul> <li> I give pagetitle the full path to a page. @@ -132,7 +134,7 @@ diff -c /usr/share/perl5/IkiWiki/Plugin/meta.pm.distrib /usr/share/perl5/IkiWiki > >> It was actually more complicated than expected. A working prototype is >> now in my `meta` branch, see my userpage for the up-to-date url. ->> Thus tagging [[patch]]. --[[intrigeri]] +>> Thus tagging patch. --[[intrigeri]] >> >>> Joey, please consider merging my `meta` branch. --[[intrigeri]] diff --git a/doc/bugs/search_for_locale_data_in_the_installed_location.mdwn b/doc/bugs/search_for_locale_data_in_the_installed_location.mdwn index dace2ca19..08af5fe2c 100644 --- a/doc/bugs/search_for_locale_data_in_the_installed_location.mdwn +++ b/doc/bugs/search_for_locale_data_in_the_installed_location.mdwn @@ -11,7 +11,7 @@ It seems like gettext only searches for locale information in /usr/share/locale, return $gettext_obj->get(shift); } -[[!tag patch]] +[[!tag patch patch/core]] -- [[ThomasBleher]] > According to my testing, this patch makes ikiwiki's localisation fail for |