diff options
| author | joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071> | 2007-08-17 05:34:59 +0000 |
|---|---|---|
| committer | joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071> | 2007-08-17 05:34:59 +0000 |
| commit | ce7596dad9c841fee92a84579be0261d3ef26407 (patch) | |
| tree | af7e9bc1c5d54258cbc398998fb456e199ec4708 /doc | |
| parent | ceae681a438a044778df212642d5f174d8bbc182 (diff) | |
* Applied Jeremie Koenig's pluggable editpage buttons patch:
- add a title to the editpage form;
- pass a reference to the list of buttons to the formbuilder_setup
hooks, so we can add ours;
- relax asumption about the possible submit values (use "Save Page"
explicitly);
- de-hardcode the submit buttons from the editpage template
(This was needed for compatability with a bug in CGI::FormBuilder
3.0401, but ikiwiki already needs a newer version.)
* Pass buttons to all other formbuilder_setup hooks too.
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/plugins/contrib/showdiff.mdwn | 5 | ||||
| -rw-r--r-- | doc/plugins/write.mdwn | 5 |
2 files changed, 8 insertions, 2 deletions
diff --git a/doc/plugins/contrib/showdiff.mdwn b/doc/plugins/contrib/showdiff.mdwn index cedc4311c..0436fdef6 100644 --- a/doc/plugins/contrib/showdiff.mdwn +++ b/doc/plugins/contrib/showdiff.mdwn @@ -19,6 +19,11 @@ which does the following: * de-hardcode the submit buttons from the editpage template (was this intended to work around something?). +> That was there to work around a bug in CGI::FormBuilder 3.0401 +> that broke FORM-SUBMIT on customised templates. That seems to be +> fixed in the newer version ikiwiki already depends on. Patch accepted. +> --[[Joey]] + ## Problems No special handling is done of concurrent edits: changes introduced diff --git a/doc/plugins/write.mdwn b/doc/plugins/write.mdwn index 3030d6558..efb65523b 100644 --- a/doc/plugins/write.mdwn +++ b/doc/plugins/write.mdwn @@ -258,8 +258,9 @@ If the hook has no opinion about whether the edit can proceed, return These hooks allow tapping into the parts of ikiwiki that use [[cpan CGI::FormBuilder]] to generate web forms. These hooks are passed named -parameters: `cgi`, `session`, and `form`. These are, respectively, the -`CGI` object, the user's `CGI::Session`, and a `CGI::FormBuilder`. +parameters: `cgi`, `session`, `form`, and `buttons`. These are, respectively, +the `CGI` object, the user's `CGI::Session`, a `CGI::FormBuilder`, and a +reference to an array of names of buttons to go on the form. Each time a form is set up, the `formbuilder_setup` hook is called. Typically the `formbuilder_setup` hook will check the form's title, and if |