* Fix aggregator to not warn when a feed contains no body content at all.

* Work around bug #420636 by, if XML::Parser crashes, running the feed
  content though Encode::decode_utf8.

2 files changed, 20 insertions, 3 deletions

diff --git a/doc/bugs/aggregate_plugin_errors.mdwn b/doc/bugs/aggregate_plugin_errors.mdwn
index 5d8b34f53..57a9869f0 100644
--- a/doc/bugs/aggregate_plugin_errors.mdwn
+++ b/doc/bugs/aggregate_plugin_errors.mdwn
@@ -13,7 +13,21 @@ When I run ikiwiki with "--aggregate" I get this error:
     Use of uninitialized value in subroutine entry at /usr/share/perl5/IkiWiki/Plugin/aggregate.pm line 414.
     Use of uninitialized value in subroutine entry at /usr/share/perl5/IkiWiki/Plugin/aggregate.pm line 414.
 
-Also, feeds from DokuWiki seem to crash the aggregate plugin completely, it's not a completely valid feed but presumably crashing is still bad.  The feed I'm seeing this with is http://www.wirelesscommons.org/feed.php
+> Fixed, this occurred when a feed did not include any body content tag.
+> --[[Joey]]
+
+Also, feeds from DokuWiki seem to crash the aggregate plugin completely,
+it's not a completely valid feed but presumably crashing is still bad.  The
+feed I'm seeing this with is http://www.wirelesscommons.org/feed.php
+
+> This is a bug in XML::Parser. Unfortunately, perl does not have a feed
+> parser that handles invalid feeds, and in particular, XML::Parser has
+> issues with feeds that claim to be encoded in utf-8 and contain invalid
+> utf sequences, as well as other encoding issues. See also [[debbug 380426]].
+> Note though that this invalid feed does not really crash the aggregate plugin,
+> it just notes that XML::Parser crashed on it and continues. This is the
+> best I can do in ikiwiki. I have filed a bug on XML::Parser about this,
+> it's [[debbug 420636]].  I've also put in a workaround, so [[done]].
 
     -- System Information:
     Debian Release: 3.1
@@ -43,4 +57,4 @@ Also, feeds from DokuWiki seem to crash the aggregate plugin completely, it's no
 
 
 Cheers,
---[[AdamShand]]
\ No newline at end of file
+--[[AdamShand]]
diff --git a/doc/bugs/aggregate_plugin_errors/discussion.mdwn b/doc/bugs/aggregate_plugin_errors/discussion.mdwn
index 691195595..3425b6d16 100644
--- a/doc/bugs/aggregate_plugin_errors/discussion.mdwn
+++ b/doc/bugs/aggregate_plugin_errors/discussion.mdwn
@@ -1,3 +1,6 @@
 I have the same problem here when I use a feed from googles shared feed. http://www.google.com/reader/public/atom/user/04715560304044435944/state/com.google/broadcast
 
-john
\ No newline at end of file
+john
+
+> I cannot reproduce any problem with this feed. Can you provide details?
+> --[[Joey]]