summaryrefslogtreecommitdiff
path: root/doc/todo
diff options
context:
space:
mode:
authorJoey Hess <joey@kodama.kitenet.net>2008-06-28 17:16:08 -0400
committerJoey Hess <joey@kodama.kitenet.net>2008-06-28 17:16:08 -0400
commit20359c493c039b9c0c791623cd410ef9e155503f (patch)
treef3bc44d9155bc8478a44e700f5ae4579dc8c415b /doc/todo
parent00503f25cdd892de521983a29f7e3d96a32801c8 (diff)
patch review
Diffstat (limited to 'doc/todo')
-rw-r--r--doc/todo/darcs.mdwn11
1 files changed, 11 insertions, 0 deletions
diff --git a/doc/todo/darcs.mdwn b/doc/todo/darcs.mdwn
index 83ffc6991..c31ce105c 100644
--- a/doc/todo/darcs.mdwn
+++ b/doc/todo/darcs.mdwn
@@ -468,5 +468,16 @@ sub rcs_getctime ($) {
I merged the two versions above and made some fixes; it is recording my web edits in darcs and showing a recent changes page.
It is in a [darcs repository](http://joyful.com/darcsweb/darcsweb.cgi?r=ikiwiki-darcs), please send patches. --[[Simon_Michael]]
+> I'd like to see at least the following fixed before I commit this: --[[Joey]]
+> * Running `darcs record $filename` in backticks is not good (security)
+> The thing to do is to open stdout to /dev/null before execing darcs.
+> * Get `rcs_recentchanges_xml` working, parsing xml with regexps does
+> not seem like a maintenance win.
+> * `rcs_notify` should be removed, it's no longer used.
+> * Some form of conflict handling. Using darcs to attempt to merge
+> the changes is I gusss optional (although every other rcs backend,
+> including svn manages to do this), but it needs to at *least* detect
+> conflicts and return a page with conflict markers for the user to fix
+> the conflict.
[[tag patch]]