diff options
| author | intrigeri <intrigeri@boum.org> | 2009-05-21 09:15:55 +0200 |
|---|---|---|
| committer | intrigeri <intrigeri@boum.org> | 2009-05-21 09:15:55 +0200 |
| commit | df6f6a1d53493de0ee4f451220b8c8d34af6642a (patch) | |
| tree | 51ed87d8494ffda4025989cf4fda8bdcd5daf8ca /doc/plugins | |
| parent | ef003f48f4a3fe8fb67fda62c70a299b07d75976 (diff) | |
| parent | f7ded1174dd8f4aec3371214bbadc1c1f7fc2e22 (diff) | |
Merge commit 'upstream/master' into pub/po
Diffstat (limited to 'doc/plugins')
| -rw-r--r-- | doc/plugins/contrib/po.mdwn | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/doc/plugins/contrib/po.mdwn b/doc/plugins/contrib/po.mdwn index 13176aac4..5b33f6716 100644 --- a/doc/plugins/contrib/po.mdwn +++ b/doc/plugins/contrib/po.mdwn @@ -372,6 +372,18 @@ daring a timid "please pull"... or rather, please review again :) >> should appear on the current page. That's why I'm testing >> `$template->param('discussionlink')`. >> +>>> Maybe I was really wondering why it says it could lead to a broken +>>> link if the cgiurl is disabled. I think I see why now: Discussionlink +>>> will be set to a link to an existing disucssion page, even if cgi is +>>> disabled -- but there's no guarantee of a translated discussion page +>>> existing in that case. *However*, htmllink actually checks +>>> for this case, and will avoid generating a broken link so AFAICS, the +>>> comment is actually innacurate.. what will really happen in this case +>>> is discussionlink will be set to a non-link translation of +>>> "discussion". Also, I consider `$config{cgi}` and `%links` (etc) +>>> documented parts of the plugin interface, which won't change; po could +>>> rely on them to avoid this minor problem. --[[Joey]] +> > * Is there any real reason not to allow removing a translation? > I'm imagining a spammy translation, which an admin might not > be able to fix, but could remove. @@ -383,6 +395,11 @@ daring a timid "please pull"... or rather, please review again :) >> delete the spammy `.po` file by hand using whatever VCS is in use. >> Not that I'd really care, but I am slightly in favour of the way >> it currently works. +>> +>>> That would definitly be confusing. It sounds to me like if we end up +>>> needing to allow web-based deletion of spammy translations, it will +>>> need improvements to the deletion UI to de-confuse that. It's fine to +>>> put that off until needed --[[Joey]] >> > * Re the meta title escaping issue worked around by `change`. > I suppose this does not only affect meta, but other things @@ -404,3 +421,5 @@ daring a timid "please pull"... or rather, please review again :) >> I'll think about it soon. >> >> --[[intrigeri]] +>> +>>> Did you get a chance to? --[[Joey]] |