summaryrefslogtreecommitdiff
path: root/doc/patchqueue
diff options
context:
space:
mode:
authorjoey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071>2007-02-22 02:35:31 +0000
committerjoey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071>2007-02-22 02:35:31 +0000
commit2a34df594e90ae844a8a990a54c6acc01861a2aa (patch)
treeed8c1489efeb0207d5b738419f9d11b9989183af /doc/patchqueue
parent9230487f19cd7307cd9d46c658b6d252f83ad691 (diff)
web commit by http://ethan.betacantrips.com/: update on this patch (it still sucks)
Diffstat (limited to 'doc/patchqueue')
-rw-r--r--doc/patchqueue/move_page.mdwn12
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/patchqueue/move_page.mdwn b/doc/patchqueue/move_page.mdwn
index 3af49bbdb..5329a7a3b 100644
--- a/doc/patchqueue/move_page.mdwn
+++ b/doc/patchqueue/move_page.mdwn
@@ -3,6 +3,16 @@ This is my first cut at a feature like that requested in [[todo/Moving_Pages]].
A bunch of obvious shortcomings exist:
* I'm not sure all the untaints are safe.
+
+ > I've looked them over.
+ >
+ > * one is safe because it only allows existing page names through.
+ > * one is safe because it follows the example of editpage in calling
+ > titlepage to sanitize.
+ > * the last one follows the example of rcs_commit in svn.pm, so I
+ > hope it's safe..
+ >
+ > --Ethan
* No precautions whatsoever are made to protect against race conditions or failures
in the rcs\_move function.
* movepage.tmpl doesn't exist yet.
@@ -50,6 +60,8 @@ before it is moved? Bail, or shrug and proceed?
> issue that occurs if the page is moved using a regular svn commit too, so
> it's not really your concern in a way. :-)
+>> I wrote a patch to address this -- it's in [[disappearing_pages]]. --Ethan
+
Could you elaborate on [[commit-internals]]? Can I assume that ikiwiki's
working copy W will always reflect a revision of the master copy M?
(That is, nobody changes W and leaves it uncommitted.) I would guess