diff options
author | Joey Hess <joey@kodama.kitenet.net> | 2008-03-21 00:24:06 -0400 |
---|---|---|
committer | Joey Hess <joey@kodama.kitenet.net> | 2008-03-21 00:24:06 -0400 |
commit | 628467125c319b623af0d60dd1e2c5817db3b1d4 (patch) | |
tree | b026897e8d2fb3806f9d9d3ec38badb552a07b06 /doc/bugs | |
parent | 80b402286c7826f555666e6b8632b78e1d1d564d (diff) |
Close meta tag for redir properly.
Diffstat (limited to 'doc/bugs')
-rw-r--r-- | doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn | 24 |
1 files changed, 8 insertions, 16 deletions
diff --git a/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn b/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn index 4d6506657..fe5366760 100644 --- a/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn +++ b/doc/bugs/RecentChanges_contains_invalid_XHTML.mdwn @@ -4,11 +4,17 @@ the end of the [[RecentChanges]] page <p></div></p> +> I'll bet this is fixed if you use the markdown 1.2 prerelease, which has +> a much less buggy html parser. (Ah, I see below that was the case.) +> --[[Joey]] + Also, there is a problem with the `<img>` tags generated by the smiley plugin which end up wrapped in a `<pre>` tag in the inline diff output. `<img>` tags is not allowed within a `<pre>` block. Maybe the smiley plugin should be disabled on [[RecentChanges]]? +> See [[Smileys_in_the_block_code]] --[[Joey]] + See the [validator output][validate] for more details. [tmpl]: http://git.ikiwiki.info/?p=ikiwiki;a=blob_plain;f=templates/recentchanges.tmpl;hb=HEAD @@ -31,24 +37,10 @@ processing and throw an error. —[Jason Blevins](http://jblevins.org/) Here is a simple patch for the refresh problem. I haven't figured out what's causing the recentchanges bug yet. - - diff --git a/IkiWiki/Plugin/meta.pm b/IkiWiki/Plugin/meta.pm - index 8a9a538..0afe1c3 100644 - --- a/IkiWiki/Plugin/meta.pm - +++ b/IkiWiki/Plugin/meta.pm - @@ -186,7 +186,7 @@ sub preprocess (@) { #{{{ - $value=encode_entities($value); - } - my $delay=int(exists $params{delay} ? $params{delay} : 0); - - my $redir="<meta http-equiv=\"refresh\" content=\"$delay; URL=$value\">"; - + my $redir="<meta http-equiv=\"refresh\" content=\"$delay; URL=$value\" />"; - if (! $safe) { - $redir=scrub($redir); - } - - --[[JasonBlevins]] +> Thanks, applied that patch. --[[Joey]] + - - - It turns out that the invalid XHTML on the recent changes page is due to |