summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjoey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071>2006-12-28 15:37:45 +0000
committerjoey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071>2006-12-28 15:37:45 +0000
commitafc45616c731601d2a00e88264d9f216e02e7a4f (patch)
treebefba9416d66280ff952fd9f26adbfe48ca367f5
parentc06adfafef8b8e462bf9ceb2856aae9de6d2f3a4 (diff)
web commit by StefanoZacchiroli: tiny bit for sharing css formatting between inline and non inline pages
-rw-r--r--doc/patchqueue/more_class__61____34____34___for_css.mdwn29
1 files changed, 29 insertions, 0 deletions
diff --git a/doc/patchqueue/more_class__61____34____34___for_css.mdwn b/doc/patchqueue/more_class__61____34____34___for_css.mdwn
new file mode 100644
index 000000000..52905abe6
--- /dev/null
+++ b/doc/patchqueue/more_class__61____34____34___for_css.mdwn
@@ -0,0 +1,29 @@
+I'm writing my own CSS for ikiwiki. During this effort I often found the need of adding more class="" attributes to the default ikiwiki templates. This way more presentational aspects of visual formatting can be delegated to CSS and removed from the HTML structure.
+
+In this patch I plan to collect changes in this direction.
+
+The first, one-liner, patch is to use a <div class="actions"> for inline page as is done with non-inlined page. This way the same CSS formatting can be applied to div.actions in the CSS, while at the moment it must be duplicated for a span.actions (which I believe is also incorrect, since it will contain an <ul>, not sure though). In case the markup should be differentiated it will still be possible relying on the fact that a div.actions is contained or not in a div.inlinepage.
+
+Here's the one-liner:
+
+ --- /usr/share/ikiwiki/templates/inlinepage.tmpl 2006-12-28 16:24:06.000000000 +0100
+ +++ inlinepage.tmpl.new 2006-12-28 16:24:04.000000000 +0100
+ @@ -31,7 +31,7 @@
+ </span>
+
+ <TMPL_IF NAME="HAVE_ACTIONS">
+ -<span class="actions">
+ +<div class="actions">
+ <ul>
+ <TMPL_IF NAME="EDITURL">
+ <li><a href="<TMPL_VAR EDITURL>">Edit</a></li>
+ @@ -40,7 +40,7 @@
+ <li><TMPL_VAR DISCUSSIONLINK></li>
+ </TMPL_IF>
+ </ul>
+ -</span>
+ +</div>
+ </TMPL_IF>
+
+ </div>
+