diff options
| author | intrigeri <intrigeri@boum.org> | 2009-01-02 18:51:32 +0100 |
|---|---|---|
| committer | intrigeri <intrigeri@boum.org> | 2009-01-02 18:51:32 +0100 |
| commit | 4ad871810d16546af614349fdecb0e1a928434c5 (patch) | |
| tree | 60d9e4b3d0f0384494ab9696d9c12c557abbb061 | |
| parent | 7ef0c19cdfcb751d2e98c9a38e7460c3e16b3268 (diff) | |
po: back to the cansave hook, as the form validation is not sufficient
Form validation works, but after trying to save invalid PO content, the user is
brought back to the page he/she was editing, without any single clue to explain
why it was not saved. The dedicated cansave hook is thus necessary.
Signed-off-by: intrigeri <intrigeri@boum.org>
| -rw-r--r-- | IkiWiki/Plugin/po.pm | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/IkiWiki/Plugin/po.pm b/IkiWiki/Plugin/po.pm index 01912f813..b51bc34f7 100644 --- a/IkiWiki/Plugin/po.pm +++ b/IkiWiki/Plugin/po.pm @@ -39,7 +39,7 @@ sub import { hook(type => "rename", id => "po", call => \&renamepages, first => 1); hook(type => "delete", id => "po", call => \&mydelete); hook(type => "change", id => "po", call => \&change); - # hook(type => "cansave", id => "po", call => \&cansave); + hook(type => "cansave", id => "po", call => \&cansave); hook(type => "canremove", id => "po", call => \&canremove); hook(type => "canrename", id => "po", call => \&canrename); hook(type => "editcontent", id => "po", call => \&editcontent); @@ -503,15 +503,6 @@ sub formbuilder (@) { } } } - - # Prevent invalid PO content to be saved. - # This cannot be done in the formbuilder_setup hook as the editpage plugin - # unconditionally sets the editcontent field's validate code later. - elsif ($form->field("do") eq "edit") { - if (istranslation($form->field("page"))) { - $form->field(name => "editcontent", validate => \&isvalidpo); - } - } } # ,---- |